Bugzilla – Bug 1016
"Plug-in Manager: Effects" GUI dialog is incorrectly titled
Last modified: 2018-08-20 11:45:44 UTC
"Plug-in Manager: Effects" GUI's dialog is incorrectly titled as it Manages Effects, Generators and Analyzers and can be invoked from any if the Effect, Generate and Analyze menus. 1) either the title should be changed to "Plug-in Manager: Effects, Generators and Analyzers" (and that way it "does what it says on the tin") 2) or we would need to split the plug-in manager into 3 separate Managers I tend to favor option 1 - but further to that the dialog is not only managing plug-ins but also the shipped built-in effects, as you can use the dialog to remove shipped effects from your effect menu to shorten it - nice :-) So the dialog tile should probably be something like "Manage Effects, Generators and Analyzers. Logging this as P3 as at the very least it needs to be Release Noted - but I suspect its priority should be higher.
Easy to change, but technically, Generators and Analysers are Effects too as is evident by all three types being listed together. Would just removing ": Effects" be effective?
(In reply to Leland Lucius from comment #1) The trouble then is that the title would be "Plug-in Manager" - but remember as I pointed out above not all the "things" that are managed are plug-ins.
If we change it to "Plug-in Manager: Effects, Generators and Analyzers" then strictly to avoid a resulting confusion from that we'd need the Path for e.g. Chirp to read "Builtin Generator: Chirp" and for e.g. Find Clipping to read "Builtin Analyzer: Find Clipping". New users without third-party plugins should see Chirp in the manager's list without scrolling down, in any case. So I think the confusion possibility is quite low for this, P4, but I don't mind changing this if the path is changed too. Leland do we need another bug for not being able to manage Contrast and Plot Spectrum? That does seem P3 to me. If there's a reason, can you remind me?
Actually, effects are simply one type of plugin and this will become more evident in 2.1.2 when more plugin types get added. The dialog will then have a more general usage...not just tied to effects as it is now. The intent of having ": Effects" in the title was that the title would change to the category of plugins being worked on while in the dialog...exactly like it does in Preferences.
(In reply to Gale Andrews from comment #3) > Leland do we need another bug for not being able to manage Contrast and Plot > Spectrum? That does seem P3 to me. If there's a reason, can you remind me? Plot Spectrum and Contrast aren't written as effects, so they don't get managed as plugins. They could be converted, but just last night I converted Contrast to a module since I thought that was the direction for that fella.
(In reply to Leland Lucius from comment #5) >> Leland do we need another bug for not being able to manage Contrast and Plot >> Spectrum? That does seem P3 to me. If there's a reason, can you remind me? > Plot Spectrum and Contrast aren't written as effects, so they don't get managed > as plugins. They could be converted, but just last night I converted Contrast > to a module since I thought that was the direction for that fella. OK thanks for reminding of the reason, that is now at bug 1019. For this bug I think you should go ahead and change the Manager title to "Plug-in Manager: Effects, Generators and Analyzers" then change the Path to describe the type of effect it is, or do nothing and we WONTFIX this. I'm happy to let you decide. My understanding is we are not in string freeze yet, so can change existing strings, right? Restored P4 for this bug. It doesn't really seem worth release noting to me.
(In reply to Gale Andrews from comment #6) "For this bug I think you should go ahead and change the Manager title to "Plug-in Manager: Effects, Generators and Analyzers"" The problem with this is, as I pointed out earlier, that it is not just plug-ins that the Manager works on - it operates on the built-in effects too, so this title would be inaccurate.
(In reply to Peter Sampson from comment #7) > (In reply to Gale Andrews from comment #6) > "For this bug I think you should go ahead and change the Manager title to > "Plug-in Manager: Effects, Generators and Analyzers"" > > The problem with this is, as I pointed out earlier, that it is not just > plug-ins that the Manager works on - it operates on the built-in effects > too, so this title would be inaccurate. Remember, whatever change is made will only be for 1 release...in 2.1.2, it will be a full blown dialog for managing all types of plugins.
(In reply to Peter Sampson from comment #7) > (In reply to Gale Andrews from comment #6) > "For this bug I think you should go ahead and change the Manager title to > "Plug-in Manager: Effects, Generators and Analyzers"" > > The problem with this is, as I pointed out earlier, that it is not just > plug-ins that the Manager works on - it operates on the built-in effects > too, so this title would be inaccurate. Also, technically, the builtin effects are plugins as well. They are managed by the plugin manager just like all the rest. Actually, the plugin manager doesn't even know they are "builtin" or not...just that they are a plugin with a plugin type of effect.
Changed title in 19baefd.
(In reply to Leland Lucius from comment #10) Confirmed ok on W7-HP 64-bit with 2.1.1 alpha nightly 10Jun15 rf98678c
(In reply to Peter Sampson from comment #11) ...and as I said, even with this change we show up the inconsistency that Built-in Generators and Analyzers are listed in Path as built-in effects. However I reopen not because of that but because the progress dialogue should say the same as the main dialogue, so not "Plug-in Manager: Effects" as now. Perhaps you could make the progress dialogue title always take whatever the title of the main window is, Leland?
Sure...I'll do it after another change, but we really need to understand that they are all just effects. Why do we need to be so pedantic when it comes to dialogs that handle them as just plain old effects, without consideration of whether they have the artificial category that we've place on them? And these dialogs are going to change again in 2.1.2 anyway because it's not going to be just for effect plugins anymore. Look for a commit shortly.
Committed in 6960270.
Tests ok on W7-HP 64-bit audacity-win-r5f985a2-2.1.2-alpha-09-sep-15
Title of the Plug-in Manager and its progress dialogue now match (Mac and Linux too).
