Created attachment 356 [details]
Replace AddVariableText  with AddCheckBox wxString

Addresses specific check box cases in Export Multiple dialogue.

Marked "patch_ready". 

Tests OK on Windows (layout unaffected and NVDA still reads the text) and on Mountain Lion (layout unaffected).

(In reply to comment #2)

Patch is unclear to me. Haven't tested, just scanned. 

* Why is row 1 code now outside the multi-column? (And btw, I prefer your indentation.)

* Why is the row 2 comment reduced? Why is its call now to AddVariableText(wxT("   ")) instead of former AddVariableText(wxT("")?


* Definitely "mLabelLabel" in the current version looks like an error. But why eliminate the  
   S.AddVariableText(_("Labels"), false);
that line apparently intended?

* The first part of your row 4 changes look right, but why eliminate the 
   mTrackLabel = S.AddVariableText(_("Tracks"), false);
line?

(In reply to comment #3)

Hopefully bugzilla will not mess up the spacing in this reply.

The original layout was:

RadioButton("")  | "Labels"
""               | CheckBox("text")
""               | TieTextBox("text")
RadioButton("")  | "Tracks"

Consequently "Labels" in rows 1 and "Tracks" in row 4 were not clickable as they were not part of the RadioButton controls.


The new layout is:

RadioButton("Labels")
"   "| CheckBox("text")
""   | TieTextBox("text")
RadioButton("Tracks")


"Labels" and "Text" are now properly attached to the radio buttons.

In order to keep the original indentation of rows 2 and 3, the previously empty AddVariableText string in line 2 has been replaced with three spaces because the second column of row 2 is no longer pushed to the indented position by row 1.

Bug replicated, patch reviewed, fix verified.  Commited in r12330

RESOLVED-FIXED