Bugzilla – Bug 1137
ESC key stopped working
Last modified: 2018-08-20 11:51:53 UTC
ESC key, for instance to abort a drag in the vertical ruler, stopped working some time between today's master and the tag wx3_stable. I am bisecting it now.
Commit f36fe29f968cc297da43464bc810a1676514ca30 did it Fixes for bugs 1122 and 1113 Several other issues were also fixed (hopefully ;-)). This is a major change to accelerator handling and keyboard capturing. Menu shortcuts, non-menu commands, label editing, navigation, and basically anything else were you might use the keyboard should be thoroughly tested.
bug1122 bug1113
Hmmm...it seems to be working here (but I've been known to completely miss the point of a report ;-)) If I click and hold within the virtual ruler, the guidelines appear as expected. Then if I hit ESC, the dragging is aborted, the lines disappear, and the track does not zoom. ESC also seems to be working when making a selection within a track...pressing ESC before releasing the mouse button will cancel the selection change and it will revert to the previous selection. What am i missing?
I reported the bug before this commit fixed it: https://github.com/audacity/audacity/commit/300f0f05a0053c8e970de38fd84de9362e9d635b I thought you made this commit just to fix this bug.
(In reply to Paul L from comment #4) > I reported the bug before this commit fixed it: > https://github.com/audacity/audacity/commit/ > 300f0f05a0053c8e970de38fd84de9362e9d635b > > I thought you made this commit just to fix this bug. Uhm, sure...yea...that's it...what you said. :-) Actually, no, I hadn't read this bug yet. It'd moved it there because I couldn't see any reason to continue to jump from the command manager, to the project, to the trackpanel. Especially since the trackpanel saw the same event twice, once from the project, and once during normal event processing. Marking fixed...
(In reply to Leland Lucius from comment #5) > (In reply to Paul L from comment #4) > > I reported the bug before this commit fixed it: > > https://github.com/audacity/audacity/commit/ > > 300f0f05a0053c8e970de38fd84de9362e9d635b > > > > I thought you made this commit just to fix this bug. > > Uhm, sure...yea...that's it...what you said. :-) > > Actually, no, I hadn't read this bug yet. It'd moved it there because I > couldn't see any reason to continue to jump from the command manager, to the > project, to the trackpanel. Especially since the trackpanel saw the same > event twice, once from the project, and once during normal event processing. > > Marking fixed... No such luck. I'll have to look at it again later today, but while it fixed the ESC, it broke the SHIFT and CTRL key behavior of the Play button. Man, if I ever get this right, I'm never touching it again! One of the main issues is that the platforms all act just a little bit differently in regards to keyboard events...especially the wxEVT_CHAR_CODE one.
Maybe the ESC key just needs a different path because wxWidgets is treating it specially? When I found the bug I found that all the other parts of TrackPanel::OnKeyDown were still reachable.
Another thing to check is that shift down and up cause proper changes of the cursor. Make some audio, select an interval, and then Shift key down and up should cause cursor to switch between i-beam and pointing finger. There is also old bug784 against me that I don't quite know how to fix. It seems to be windows only. Actually I think that's not just a spectral selection problem, rather it is also the case that if you shift-drag on windows, the finger goes back to i-beam. If you don't fix that, I suppose we can live with it as we have been doing.
It gets even stranger...press and hold the CTRL key, then press and release the SHIFT key. The Play button changes. Now, release CTRL and revers it. Press and hold the SHIFT key, then press and release the CTRL key. :-) Funny enough, that's a good sign.
Should be complete resolved as of: 04d026e5bc44f3dc7170713294c6b9ed8aa01a3e
Testing on Mac El Capitan on 01a95c5-2.1.3-alpha-13-feb-16 and Testing on W10 on audacity-win-r4d154c4-2.1.3-alpha-18-feb-16 The Esc key seems to work fine for aborting a drag in the vertical ruler (Paul's test) - also works for aborting a selection with a track (Leland's test). Looks to be fixed for these two platforms.
Tested at 396a6f0 from audacity/audacity on Linux. As above, cancelling both the drags work correctly, so flagging this as Test-OK-Lin.
Marked RESOLVED - FIXED.
