Bug 1273 – Metadata Editor: Closing/cancelling editor when a cell is open requires two clicks (and asserts on Linux)

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1273 - Metadata Editor: Closing/cancelling editor when a cell is open requires two clicks (and asserts on Linux)


Summary:	Metadata Editor: Closing/cancelling editor when a cell is open requires two c...

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Formats
Version:	2.1.2
Hardware:	Per OS macOS and Linux

Importance:	P4 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Duplicates:	1259 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2015-12-11 10:16 UTC by Gale Andrews
Modified:	2018-08-20 11:51 UTC (History)
CC List:	10 users (show)

See Also:
Steps To Reproduce:	1 On Mac, open Metadata Editor and double-click a value cell to open it. Click OK or Cancel. The cell is closed but the Editor does not close, requiring a second click on OK or Cancel which is not the case in 2.1.0. 2 On Linux Ubuntu 14.04, step 1 only reproduces sometimes for most value cells, but always reproduces when pressing OK or Cancel when the Genre cell is open. The next OK or Cancel then produces an assertion error (backtrace attached). Opening any value cell then pressing ESC followed by ESC, OK or Cancel produces the same assertion.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	gale: Regression+ petersampsonaudacity: Test‑OK‑Mac+ richard: Test‑OK‑Lin+

Attachments
backtrace for assertion (2.73 KB, text/plain) 2015-12-11 10:16 UTC, Gale Andrews	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2015-12-11 10:16:30 UTC

Created attachment 654 [details]
backtrace for assertion

Regression on 2.1.1. This replaces bug 1259 which was a partial description.

Comment 1 Gale Andrews 2015-12-11 10:19:27 UTC

*** Bug 1259 has been marked as a duplicate of this bug. ***

Comment 2 Gale Andrews 2016-04-22 18:39:18 UTC

As of today I cannot reproduce the assertion (step 2) on Ubuntu 14.04 in release builds. 

I can still reproduce the two clicks required to close the Metadata Editor on El Capitan (step 1).

Comment 3 Paul L 2016-06-23 03:02:53 UTC

Since the Linux problem was not reproducible, I will close this, having fixed the
Mac problem.  I was careful to restore the ESC key behavior too of version 2.1.1.  Commit comments:

Bug1273: Restore 2.1.1 behavior of Metadata editor OK, Cancel, ESC...
    
    Click twice on a grid cell; Cancel or OK dismiss the dialog.  But ESC does not,
    and a second ESC does not either.  ESC dismisses the dialog only if the focus
    is not in the grid.

https://github.com/audacity/audacity/commit/c1ca055fa4fc42b382874de40f2d72f46becd92b

Comment 4 Peter Sampson 2016-07-09 10:15:44 UTC

Testing on c9422aa 08Jul16 on Mac El Capitan

Clicking the OK or Cancle button now returns the user fortwith to the main SAudacity window, succesfully dismissing the Metadata editor dialg -  looks to be fixed ok on Mac

Comment 5 Richard Ash 2016-11-26 16:22:33 UTC

Tested at 396a6f0 from audacity/audacity on Linux. Works correctly (closes on first click keeping the entered value, no backtrace), so flagging this as Test-OK-Lin.

Comment 6 David Bailes 2016-11-28 06:54:54 UTC

(In reply to Paul L from comment #3)
> Since the Linux problem was not reproducible, I will close this, having
> fixed the
> Mac problem.  I was careful to restore the ESC key behavior too of version
> 2.1.1.  Commit comments:
> 
> Bug1273: Restore 2.1.1 behavior of Metadata editor OK, Cancel, ESC...
>     
>     Click twice on a grid cell; Cancel or OK dismiss the dialog.  But ESC
> does not,
>     and a second ESC does not either.  ESC dismisses the dialog only if the
> focus
>     is not in the grid.
> 
> https://github.com/audacity/audacity/commit/
> c1ca055fa4fc42b382874de40f2d72f46becd92b

This has affected the behaviour on Windows, and introduced a bug.
If the grid is the focus, and you haven't got a cell open for editing, then pressing ESC should close the dialog. A user opens the dialog, immediately presses ESC to close the dialog, but it doesn't close as it should.

Comment 7 David Bailes 2016-11-28 07:04:46 UTC

(In reply to David Bailes from comment #6)
> (In reply to Paul L from comment #3)
> > Since the Linux problem was not reproducible, I will close this, having
> > fixed the
> > Mac problem.  I was careful to restore the ESC key behavior too of version
> > 2.1.1.  Commit comments:
> > 
> > Bug1273: Restore 2.1.1 behavior of Metadata editor OK, Cancel, ESC...
> >     
> >     Click twice on a grid cell; Cancel or OK dismiss the dialog.  But ESC
> > does not,
> >     and a second ESC does not either.  ESC dismisses the dialog only if the
> > focus
> >     is not in the grid.
> > 
> > https://github.com/audacity/audacity/commit/
> > c1ca055fa4fc42b382874de40f2d72f46becd92b
> 
> This has affected the behaviour on Windows, and introduced a bug.
> If the grid is the focus, and you haven't got a cell open for editing, then
> pressing ESC should close the dialog. A user opens the dialog, immediately
> presses ESC to close the dialog, but it doesn't close as it should.

Open bug for this:
http://bugzilla.audacityteam.org/show_bug.cgi?id=1550

Comment 8 Gale Andrews 2016-11-30 18:29:31 UTC

RESOLVED - FIXED:  problems in this bug now fixed but I agree bug 1550 is a problem. I was not intending to hold up the entirety of the 2.1.1 grid behaviour on Mac as what we wanted.