Bug 1279 – Windows: VST: ReaPlugs plug-ins do not see user presets saved in 2.1.0/2.1.1

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1279 - Windows: VST: ReaPlugs plug-ins do not see user presets saved in 2.1.0/2.1.1


Summary:	Windows: VST: ReaPlugs plug-ins do not see user presets saved in 2.1.0/2.1.1

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	VST
Version:	2.1.3
Hardware:	Per OS Windows (all)

Importance:	P3 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:	patch_closed

Depends on:
Blocks:	665
	Show dependency tree / graph

Reported:	2015-12-15 08:14 UTC by Gale Andrews
Modified:	2019-05-13 07:39 UTC (History)
CC List:	7 users (show)

See Also:	1338
Steps To Reproduce:	1 Install the ReaPlugs VST FX Suite from http://www.reaper.fm/reaplugs/ . 2 Enable the plugins in 2.1.0 or 2.1.1. Open for example ReaEQ, ReaDelay or ReaGate and save a user preset. Exit Audacity. Confirm the presets are visible in pluginsettings.cfg. 3 Launch HEAD and open the ReaPlug effects for which you added user presets. Look in the Manage menu. The presets are missing.
Release Note:	// See bug 665.
First Git SHA:
Group:	VST
Workaround:
Closed:	2019-05-13 00:00:00

Flags:	gale: Regression+

Attachments
Crash when using ReaEQ (140.21 KB, application/zip) 2015-12-15 08:14 UTC, Gale Andrews	Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2015-12-15 08:14:30 UTC

Created attachment 655 [details]
Crash when using ReaEQ

Regression on 2.1.0/2.1.1.

Comment 1 Paul L 2016-04-05 15:23:29 UTC

No success yet trying to reproduce this.  Are there more precise steps?

Comment 2 Gale Andrews 2016-04-22 07:48:16 UTC

(In reply to Paul L from comment #1)
> Are there more precise steps?
Not really. Are you on Win 8.1? Real hardware or VM? These crash on Win 7 and Win 10 for me.

A simple way should be to run ReaEQ and simply click (repeatedly if necessary) "Add Band" or "Remove Band". "Add Band" should add a tab and "Remove Band" should remove the selected tab. But they don't.

Comment 3 Gale Andrews 2016-05-22 13:28:45 UTC

James committed Tony Kirkland's fix at https://github.com/audacity/audacity/commit/26fc699 so moved to DEVEL - FIX MADE.

Comment 4 Gale Andrews 2016-06-01 12:03:32 UTC

Tony reported off list that this was due to an infinite loop inside a windows API function called IsDialogMessage(). The Reaper plugins are unusual because they are created with Windows controls in the plugin - almost all other VSTs have their own custom controls and just appear as one big control that accepts mouse clicks. Thanks to Tony for the fix. 

I tried most of these effects on Windows 7 and Windows 10 and did not receive crashes, navigating with mouse or keyboard in graphic or text interface.  

So I REOPENED the bug demoted to P3 for not being able to use User Presets saved in 2.1.0 or 2.1.1. Steps to reproduce have been adjusted.

Also added a new bug 1399 for ReaEQ tabs not being capable of enable or disable while processing.

Comment 5 Paul L 2016-06-01 12:20:35 UTC

A different operating system, but could there be some analogy with the freezing problem in Mac in Bug 1338?

Comment 6 Peter Sampson 2019-05-13 07:39:48 UTC

Given that this relates to long superseded versions of Audacity we ca just close this bug.  It has effectively been resolved-fixed by later versions of Audacity.

Also I recall no users complaining about this for a long while now.