Bug 1318 – Mac: Window close button on an effect loses all focus, requiring force quit

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1318 - Mac: Window close button on an effect loses all focus, requiring force quit


Summary:	Mac: Window close button on an effect loses all focus, requiring force quit

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	Built-in FX
Version:	2.1.3
Hardware:	Mac macOS

Importance:	P1 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-01-27 12:51 UTC by Gale Andrews
Modified:	2018-08-20 11:45 UTC (History)
CC List:	7 users (show)

See Also:	1291
Steps To Reproduce:	1 New project. Open a Generator or real-time preview effect and click the red window close button. Any mouse clicks now "ding", key presses do nothing and Audacity must be force quit. 2 New project, create some audio. Open any generator, effect or analyzer except Contrast and Plot Spectrum. Any mouse clicks now "ding", key presses do nothing and Audacity must be force quit.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	gale: Regression+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2016-01-27 12:51:03 UTC

Regression on 2.1.1. Tested on El Capitan. 

Cancel or escape do not show this issue - but see bug 1291 (moonphase P4).

Comment 1 Gale Andrews 2016-02-05 08:15:03 UTC

RTP effects no longer seem to be affected in a build tested today, unless there is some moonphase element. Non-RTP effects are still affected.

Comment 2 Paul L 2016-04-23 08:31:08 UTC

Is something missing from (2) in Steps to Reproduce?

I have Yosemite and for number 1, I do see the problem after ESC as well as red button.

Comment 3 Paul L 2016-04-23 08:51:34 UTC

Fixed https://github.com/audacity/audacity/commit/879ecefdaac73a0dec3a278062748ac4e53fee36

Comment 4 Peter Sampson 2016-04-24 09:06:08 UTC

Tested on nightly 24Apr16 bc80ffe on Macbook Pro El Capitan

Tests ok with Generators and with RTP effects - red window close button works as it should.

Also tested Step 2 in yhe Steps to reproduce and that worked fine.

Looks to be fixed.

Comment 5 Paul L 2016-04-24 10:36:01 UTC

Fixed again, so that generators and effects on Windows still work.  Please
verify both platforms again.

https://github.com/audacity/audacity/commit/3dc752401450ce812086bd027c4d7e505a20275d

Comment 6 Gale Andrews 2016-04-24 23:34:53 UTC

(In reply to Paul L from comment #5)
I rested on Mac and Windows (and on Ubuntu for good measure), trying many combinations of real-time preview and standard effects, also with opening new windows with real-time preview effects. I did not see any problems.