Bugzilla – Bug 1365
Append Record icon hard to see and confusing
Last modified: 2018-08-20 11:46:12 UTC
I think we will have to use another colour for the overlay, perhaps white. Or, show only the Skip to End icon in red.
(In reply to Gale Andrews from comment #0) >Or, show only the Skip to End icon in red. Or perhaps the Skip to End icon in red with a red ring around it
Updated Append Record button icon in commit: https://github.com/audacity/audacity/commit/f1909cb88
I just saw the new button image. It's very nice. If I zoom close with Windows magnifier, I see that it doesn't have the slight dark gray shadow that the other buttons have. Will anyone care strongly about that?
(In reply to Paul L from comment #3) > it doesn't have the slight dark gray shadow that the other buttons have That would give it a little more apparent depth. Also it appears not to be the same as the Skip to End icon, not only because of the circle which seems to mean we lack the icon's ending bar, but also because in the Skip to End icon the leftmost arrow runs into the following arrow, but the arrows appear separated in the new icon. So it's a great improvement but if identification with Skip to End matters, it's not totally right.
This commit causes the Play button to turn into a black square during scrubbing.
(In reply to Paul L from comment #5) OK, yes I see that. I've asked on devel if anyone knows the 'right' way to do this. I'll mark this as assigned to myself while we wait for a reply.
(In reply to Gale Andrews from comment #4) > Also it appears not to be the same as the Skip to End icon. That's intentional for two reasons: 1) Functionally it is not quite the same as "skip to end". To see this, generate a 30 second tone, then click on the track about 10 seconds after the end of the track. From this position, "skip to end" will jump backwards to the end of the track (symbolised by the vertical line at the point of the double arrow). In the case of "append record" it does not jump back to the end of the track (hence no vertical line) - recording commences from the current position. 2) The double arrow needs to be smaller than in the "FFwd" icon so as to fit within the recording icon. The proportions of the double arrow have been shaped for maximum clarity at this small scale. > it doesn't have the slight dark gray shadow that the other buttons have Currently we lack consistency with the "grey shadow". The brown square on the "stop" button has only a slight hint of a shadow, whereas the new "shift play" icon has a much stronger dark green edge, and the FFwd has a mid-grey "shadow" but not on the vertical line. When we know the 'correct' way to update these icons I think it would be worth updating the full set so that they can be more consistent in style.
Well, I've just been using audacity-win-r4fb4b4b-2.1.3-alpha-18-may-16 on W10 not realizing that this change was in this nightly. And I must say that the change of icon really caught my eye when I held down the Shift key - in a way that the previous long-standing version never did. For me this is a big improvement, I like it. Test ok on W10 audacity-win-r4fb4b4b-2.1.3-alpha-18-may-16
tests ok on Macbook Pro El Capitan 7e0de9a 22May16 nice and eye-catching on the Mac too
I still see a black square in the Play button when I scrub. Is it unclear how to fix that problem? Shall I do it?
(In reply to Paul L from comment #10) Paul wrote: >I still see a black square in the Play button when I scrub. I think that that is a different bug - so I suggest that you raise a fresh bug for it Paul - and yes, please fix it if you can.
Peter, that bug was caused by the same commit that created the new button images. That commit should be reverted and redone.
I fixed the play button at e68cfc3a0597bddc13988b9264576074a2c401ae As to the new image, I like them, but one might want a slight gray shadow at the edge to be consistent with the other images. Use Windows Magnifier to see what I mean.
(In reply to Steve Daulton from comment #7) > "skip to end" will jump backwards to the end of the track (symbolised > by the vertical line at the point of the double arrow). In the case of > "append record" it does not jump back to the end of the track (hence no > vertical line) - recording commences from the current position. Something of a moot point I feel, given the space between the end of the tone and the new recording is filled with silence. But probably Skip to End wasn't right in the first place anyway. Would not |>> have been a better visual for what happens? The new append-record icon could be construed to mean a rightwards-moving recording cursor (as opposed to the fixed recording playhead of scrolling recording). I don't think it's a huge concern, but I think the requirement for a circle is limiting, even though I can see why we might want a circle. The Loop-play icon does not attempt to contain itself in a triangle, but uses the idea of a circle to suggest repetition.
(In reply to Paul L from comment #13) Paul wrote: >I fixed the play button at e68cfc3a0597bddc13988b9264576074a2c401ae Tested on W10 - the proper Scrub-play button now appears again rather that the blacked-ou square
(In reply to Paul L from comment #13) Why are you fixing bugs that are assigned to someone else? Don't you have bugs of your own to fix?
(In reply to Steve Daulton from comment #16) Perhaps I misunderstand what "Assigned" means. Perhaps Gale could clarify.
The bug as stated appears to be fixed now, so I've unassigned myself from it and marked it "fix made".
(In reply to Steve Daulton from comment #17) > Perhaps I misunderstand what "Assigned" means. Perhaps Gale could clarify. According to the Bugzilla help text it means "This bug is not yet resolved, but is assigned to the proper person. From here bugs can be given to another person and become NEW, or resolved and become RESOLVED." Confirming I no longer see the black square on Mac for the Play button when scrubbing.
