Bug 1367 – Intermittent Assert error when Timer Record progress dialog completes

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1367 - Intermittent Assert error when Timer Record progress dialog completes


Summary:	Intermittent Assert error when Timer Record progress dialog completes

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	Built-in FX
Version:	unspecified
Hardware:	Per OS All

Importance:	P4 Repeatable
Assigned To:	Steve Daulton

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-03-30 12:16 UTC by Steve Daulton
Modified:	2018-08-20 11:46 UTC (History)
CC List:	5 users (show)

See Also:
Steps To Reproduce:	One way to reproduce the assert is: 1) New project 2) Timer Record and auto-save the project 3) Timer Record and auto-save the project (again) The assert error occurs when the second recording gets to the end. The assert may not happen every time, but keep repeating and it is likely to happen quite soon
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2016-03-30 12:16:04 UTC

See http://audacity.238276.n2.nabble.com/Timer-Recording-Improvements-tp7572995p7573027.html

I see what the problem is, but easier to fix 'after' the new "Timer Record enhancements" have been committed.

Comment 1 Steve Daulton 2016-03-30 12:19:10 UTC

The actual error applies to all platforms, but may only show up on some platforms and may require a debug build to see the bug.

Changed platform to "All".

There is a remote possibility that this could cause a freeze if it occurs in a release build.

Comment 2 Gale Andrews 2016-04-01 12:12:45 UTC

The error did occur in Ubuntu in release builds because of the Debug level allowed on that platform.

Steve committed a fix at https://github.com/audacity/audacity/commit/1271056 .

Comment 3 Steve Daulton 2016-04-01 15:54:51 UTC

Thanks for adding the commit URL Gale.

Ideally this fix should be tested in debug builds on all platforms. The Assert is "stronger" now than before in that it previously had a "fudge factor" safety margin of 1%. The current assert has no fudge factor and is a straight "<=" test.

Comment 4 Steve Daulton 2017-01-12 08:02:31 UTC

This bug seems to be have been fixed early last year.

Comment 5 Gale Andrews 2017-01-13 21:31:49 UTC

(In reply to Steve Daulton from comment #4)
It's P4 and requires to test in debug builds on all platforms (which I never usually build because we don't release debug builds). Will have to wait a bit longer, unless someone else tests.

Comment 6 Gale Andrews 2017-01-14 21:10:31 UTC

I don't see the assert mentioned on -quality in debug builds of HEAD on Windows, Mac or Linux.

On WIn 10 x64 I built 758eae6 (that commit is a day before Steve's fix) but can't test because on that machine, debug builds hit bug 42. An assert I do get at 758eae6 if I press Stop in a vain attempt to stop the recording is:   

c:\git master\audacity\src\widgets\progressdialog.cpp(1572): assert "(nGaugeValue >= 0) && (nGaugeValue <= 1010)" failed in TimerProgressDialog::Update().

This assert does not occur in a Debug build of HEAD if I try to stop an out of control recording. 

Is this information sufficient to resolve the bug?

Comment 7 Steve Daulton 2017-01-18 16:07:24 UTC

(In reply to Gale Andrews from comment #6)
I think there is sufficient evidence that the fix works as intended.

Comment 8 Gale Andrews 2017-01-18 19:57:57 UTC

(In reply to Steve Daulton from comment #7)
Good. Still qualifies as "Quick Fixed".