Bug 1402 – Timer Record Disk Space Warning durations end in "and" if minutes is zero

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1402 - Timer Record Disk Space Warning durations end in "and" if minutes is zero


Summary:	Timer Record Disk Space Warning durations end in "and" if minutes is zero

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.1.3
Hardware:	Per OS All

Importance:	P4 Repeatable
Assigned To:	Mark Young

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-06-15 10:52 UTC by Gale Andrews
Modified:	2018-08-20 11:45 UTC (History)
CC List:	6 users (show)

See Also:
Steps To Reproduce:	1 Launch Audacity, open Timer Record, set Duration to more time than you have space for, e.g. 40 days, and ensure Duration minutes is set to zero. OK. 2 The Disk Space Warning appears. The "Planned recording duration" ends in "and" e.g. "960 hours and" instead of 960 hours and 0 minutes". 3 Similarly, if you configure your disk space and project rate so that recording time remaining in the Status Bar would appear as "however many hours it is" and 0 minutes, then "Recording time remaining on disk" in this "Disk Space Warning" appears with "and" at the end instead of "and 0 minutes".
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ gale: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2016-06-15 10:52:39 UTC

Comment 1 Gale Andrews 2016-10-02 22:34:40 UTC

James committed Mark's fix for this https://github.com/audacity/audacity/commit/a4ae301 .

Comment 2 Peter Sampson 2016-10-10 11:26:36 UTC

Tested on W10 audacity-win-r79c5834-2.1.3-alpha-09-oct-16 and on Mac 07Oct16 2add979

On both platforms steps 2 and 3 display correctly with 

... X hours and 0 minutes

And both the messgaes are niclesingularized when  remainin time is:

... X hours and 1 minute

Comment 3 Gale Andrews 2016-10-10 13:41:48 UTC

OK on Linux.  Also tested recording time remaining was still respecting changes in project rate and bit depth.