Bug 1409 – Contrast: Closing "Help on the Internet" loses focus

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1409 - Contrast: Closing "Help on the Internet" loses focus


Summary:	Contrast: Closing "Help on the Internet" loses focus

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.1.3
Hardware:	Per OS macOS

Importance:	P4 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-06-21 12:38 UTC by Gale Andrews
Modified:	2018-08-20 11:51 UTC (History)
CC List:	6 users (show)

See Also:	1268
Steps To Reproduce:	1 Use the ZIP build of Audacity or rename the "help" folder. 2 Generate some audio, then Analyze > Contrast... . 3 Click the "Help" button. 4 "Help on the Internet" appears. In that dialogue, press the "Close" button. 5 Instead of focus returning to Contrast, focus is returned to the main window. This is confusing, especially given due to bug 1119 there is no "Window" menu which most users are familiar with to switch to another window in the application.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	gale: Regression+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2016-06-21 12:38:53 UTC

Regression on 2.1.1.

Comment 1 Peter Sampson 2016-06-21 13:04:57 UTC

Testing this on W10 audacity-win-r02ce3c3-2.1.3-alpha-21-jun-16

I get the same funny little window that I reporrted for Timere Record in Bug #1408

Comment 2 Paul L 2016-06-21 13:13:21 UTC

Fixed at Fixed at
https://github.com/audacity/audacity/commit/7808064ae10fbc99bba0ba4c30807e3a0ba69ae2

Comment 3 Gale Andrews 2016-06-21 14:19:00 UTC

(In reply to Peter Sampson from comment #1)
> I get the same funny little window that I reporrted for Timere Record 
> in Bug #1408
You won't see that when you next update your build. 

(In reply to Paul L from comment #2)
> Fixed at
https://github.com/audacity/audacity/commit/7808064 
Doesn't work correctly for me in release configuration. On clicking the help button in Contrast, the "Help on the Internet" dialogue does not have focus. After giving "Help on the Internet" focus and dismissing it, focus is neither in Contrast or the main window. The only improvement is that I can still see Contrast after dismissing the help dialogue.

Comment 4 Peter Sampson 2016-06-22 10:47:51 UTC

Testing onon Mac El Capitan d6187f6 21Jun16

I get the same result as Gale - no focus on either the Contrast or the main Audacity Window.  On W10 the focus is returned to the Contrast dialog.

Comment 5 Paul L 2016-06-22 11:02:39 UTC

Fair enough, but allow that I have made the window not-lowered.

So far I have figured it out, not-lowered but not focused is the compromise with the other development that allows the modal help to be non-freezing.

I might have to go the route of making much duplicate code for the modal and nonmodal cases.

Comment 6 Gale Andrews 2016-06-22 13:09:30 UTC

I renamed the bug to "Contrast: Closing "Help on the Internet" loses focus". But for sighted users, it is actually much better than before.

Comment 7 Paul L 2016-06-22 13:44:09 UTC

Try this now:
https://github.com/audacity/audacity/commit/9d506cd850fe371d737b96cd9d84a4921150d1d1

Comment 8 Peter Sampson 2016-06-30 15:16:03 UTC

Works for me testing on d618716 29Jun build on Mac that Gale built for me

and on W10 audacity-win-r10f77bc-2.1.3-alpha-29-jun-16

Comment 9 Peter Sampson 2016-07-07 09:53:29 UTC

Tests ok on Mac El Capitan on r145a54d 05Jul16

Comment 10 Gale Andrews 2016-07-07 14:04:51 UTC

I also tested on Mac closing the Help dialogue with ESC and red window close button. 

On Linux closing the "real" Help dialogue with ESC or Close button leaves focus in Contrast as intended.