Bug 1440 – Cancelling Export Multiple by labels containing illegal characters exports the cancelled file with empty name.

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1440 - Cancelling Export Multiple by labels containing illegal characters exports the cancelled file with empty name.


Summary:	Cancelling Export Multiple by labels containing illegal characters exports th...

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	Formats
Version:	2.1.3
Hardware:	Per OS All

Importance:	P3 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-07-10 12:56 UTC by Gale Andrews
Modified:	2018-08-20 11:51 UTC (History)
CC List:	7 users (show)

See Also:
Steps To Reproduce:	1 Create audio in a track and Edit > Duplicate the track. 2 Rename the second track to include an illegal character for your OS, e.g. / on Windows or Linux or : on Mac. 3 Add a label including an illegal character for your OS. 4 File > Export Multiple... and choose the "Tracks" radio button. Click "Export". 5 OK on Metadata Editor if it appears for the first track. Cancel or ESC the Save As... dialogue that pops up for the second track. The Export Multiple "cancelled" dialogue appears which shows all exports were cancelled. ESC the cancelled dialogue. 6 Change the radio button to "Labels" and click "Export". 7 Cancel or ESC the Save As... dialogue. If your Import / Export Preference is set to show Metadata Editor, the Edit Metadata tags dialogue appears. If your preference is to hide Metadata Editor, the file exports with an empty file name (extension only). If labels containing a valid file name exist either side of the invalid label, those files are also exported, with the expected file names. Does this point to making better behaviour for the Tracks case, so that all tracks with valid track names export and only cancelled ones do not?
Release Note:	GROUP : Export Multiple * '''If you enter an invalid character in any labels and cancel the resulting Save As... dialogue(s), files with empty names (extension only) will be exported for the files you cancelled.'''
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ gale: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2016-07-10 12:56:49 UTC

(I intend to create a new Export Multiple group in the Release Note, it is not a mistake).

Comment 1 James Crook 2016-07-15 11:25:57 UTC

DEVEL-FIX MADE
https://github.com/audacity/audacity/commit/7c7fc55bc254cef279202f87ba9bbce87d2ae065

I made exporting tracks more like labels too, in that they too continue on with exporting after a bad name.

Cancelling the metadata editor still behaves as before.  Is that what we want?  I don't know.  But if it isn't what we want, we need to write up somewhere policy on cancelling of multi-step operations, chains being another case.

Comment 2 Peter Sampson 2016-07-20 09:35:20 UTC

Testing on Mac El Capitan rcf2625a

For the second track with the illegal character the export dialog now pops up a fresh dialog labelled "Save As..."  - it enables the user to change the filename to be exported to but it already replaces the illegal character with an underscore so th user can just accep that.

But becuase the only Mac illegal character is a colon the warning message looks a little odd:
" ... You cannot use any of::"

That double colon, while strictly accurate, looks more than a little odd imo.

Also when there is only one illegal character the "any of" doesn't really apply.

Comment 3 Peter Sampson 2016-07-20 09:40:29 UTC

Tests ok on W10 audacity-win-rcf2625a-2.1.3-alpha-18-jul-16

But here the warning message looks ok as there are several illegal characters and the illegal colon is not next to the grammar colon.

Comment 4 James Crook 2016-09-07 11:13:15 UTC

RESIDUAL - FIX MADE :-)
https://github.com/audacity/audacity/commit/b56ea0599b935a677cbbe449bc4a6ad57a45eafd

Comment 5 Peter Sampson 2016-09-08 09:34:26 UTC

(In reply to James Crook from comment #4)
Looking good on Mac El Capitan 43b4d3c 08Aug16

Residual issue on Mac fixed nicely

And still oks good on W10 audacity-win-r43b4d3c-2.1.3-alpha-08-sep-16

Comment 6 Gale Andrews 2016-09-08 12:41:55 UTC

Tested the behaviour with Export Multiple by labels OK on Linux.

(In reply to James Crook from comment #1)
> I made exporting tracks more like labels too, in that they too
> continue on with exporting after a bad name.
Sounds good, but there is a crash problem if you cancel the character replacement (bug 1510).

> Cancelling the metadata editor still behaves as before.  Is that what we 
> want?  I don't know. 
Nor me. But if you have dozens of tracks and want to abort the whole export multiple, cancelling dozens of Metadata Editors will get annoying. Perhaps have a dialogue choice if you cancel Metadata Editor in Export Multiple: 

( ) Abort entire Export Multiple process
( ) Abort just this export and continue.

Comment 7 James Crook 2016-09-10 15:11:04 UTC

Bug 1510 exposed a mistake in the 'fix' for this bug and the commit to resolve 1510 means that this bug needs to be retested.

Comment 8 Gale Andrews 2016-09-11 15:18:34 UTC

(In reply to James Crook from comment #7)
> Bug 1510 exposed a mistake in the 'fix' for this bug and the commit 
> to resolve 1510 means that this bug needs to be retested.
Done. I tested Export Multiple by labels and by tracks. Tried stereo tracks, mono tracks, mixture of mono and stereo tracks, offset tracks and Export Multiple by labels and by tracks when there was also a label track. 

Also tested that entering a name or prefix with illegal characters in either text box in Export Multiple was trapped by Save As... .  

Tip: Perhaps when you reopened this bug you should have reset the flags so that it did not appear tested.