Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 1442 - Cyclic tabbing through a label track is broken
Cyclic tabbing through a label track is broken
Status: RESOLVED QUICKFIXED
Product: Audacity
Classification: Unclassified
Component: Labels
2.1.3
Per OS Other
: P4 Repeatable
Assigned To: Default Assignee for New Bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-07-10 17:19 UTC by Paul L
Modified: 2018-08-20 11:45 UTC (History)
7 users (show)

See Also:
Steps To Reproduce:
Generate some sound. Create a label track. Create at least two non-overlapping labels. Put the yellow focus on the label track. Hit TAB repeatedly. Observe that in 2.1.2, with two labels, you cycle through three states -- in the last, none of the labels is highlighted, but the selection is the last label. In 2.1.3, after the last label loses the highlight, you are stuck in that state and TAB does nothing.
Release Note:
First Git SHA:
Group: ---
Workaround:
Closed: 2018-08-20 00:00:00
petersampsonaudacity: Test‑OK‑Win+
petersampsonaudacity: Test‑OK‑Mac+
gale: Test‑OK‑Lin+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul L 2016-07-10 17:19:26 UTC

    
Comment 1 Paul L 2016-07-10 17:23:06 UTC
This bug was introduced at:

uthor: Paul Licameli <paul.licameli@gmail.com>  2016-06-25 14:18:23
Committer: Paul Licameli <paul.licameli@audacityteam.org>  2016-06-25 19:14:05
Parent: ae14cb0dbccf9587b7a13f5ddc49c2b27acfec1e (Allow tabbing to the button on the time ruler...)
Child:  9f6eedf6e4415b31d4eb2a65e3845f5d287e7fd1 (Bug682: fix Tab key navigation in Preferences, particulary Keyboard)
Branches: includeWxWidgets, labels, labels2, master, remotes/alex-chapiro/master, remotes/audacity/master, temp
Follows: Audacity-2.1.2
Precedes: 

    Compensate for wxW 3 tab navigation deficiencies on Mac...
    
    ... using char hook event handlers.  We don't need to go the extreme length
    of patching wxWidgets source.
Comment 2 Paul L 2016-07-10 17:26:05 UTC
Quick Fixed here:
https://github.com/audacity/audacity/commit/2543eacd9435e43079a584f327674e115449cedc

But with this difference from 2.1.2 behavior, which I hope we agree is an improvement:

After highlight leaves the last label, the selection also becomes empty.

If we don't agree to this change of behavior, I will find a different fix.  As it is, this is the easy one line fix.
Comment 3 Paul L 2016-07-13 11:33:11 UTC
The symptom still happens, but now only in the very special case, that you have a point label exactly at 0.

This should also admit a simple fix.
Comment 4 Paul L 2016-07-13 14:21:37 UTC
Fixed that special case here:
https://github.com/audacity/audacity/commit/35514b7a3ed3f235a32e5e187d2a363ee24d8860
Comment 5 Peter Sampson 2016-09-21 13:26:12 UTC
Tested on W10 audacity-win-rf993f1e-2.1.3-alpha-20-sep-16 
and on Mac El Capitan 285f6dc 21Sep16

Tabbing now tabs to each label (region and point labels) but after tabbing from the final label, rather than cycling throgh to the first label the cursor is instead moved to Time=0 and then the next used of Tab takes you to the first label.  I am unsure if this is expected behavior or not?
Comment 6 David Bailes 2016-10-27 05:29:30 UTC
(In reply to Peter Sampson from comment #5)
> Tested on W10 audacity-win-rf993f1e-2.1.3-alpha-20-sep-16 
> and on Mac El Capitan 285f6dc 21Sep16
> 
> Tabbing now tabs to each label (region and point labels) but after tabbing
> from the final label, rather than cycling throgh to the first label the
> cursor is instead moved to Time=0 and then the next used of Tab takes you to
> the first label.  I am unsure if this is expected behavior or not?

Discussion on Audacity-quality was of the opinion that it wasn't the desired behaviour, so I've removed the empty selection (cursor) at time zero from the cycle:
https://github.com/audacity/audacity/commit/edb99485da0a5518c8915c0c371b4646e59a0b9c
Comment 7 Peter Sampson 2016-10-27 10:13:19 UTC
Tested on Mac El Capitan edb9948 27Oct16

Tests ok with no null slection at time=0.  

Tested both forward next label with Tab and backward to precious label with Shift+Tab - both cycled correctly with no null T=0 selection.

Will test on W10 when the next nightly arrives
Comment 8 Peter Sampson 2016-11-05 10:39:32 UTC
Tested on W10 audacity-win-rf296c76-2.1.3-alpha-05-nov-16

Tests ok with no null slection at time=0.  

Tested both forward next label with Tab and backward to precious label with Shift+Tab - both cycled correctly with no null T=0 selection.
Comment 9 Gale Andrews 2016-12-03 21:59:11 UTC
OK on Ubuntu 14.04. Also tested overlapped labels and a label having text that goes past the end of the visible project.