Bug 1453 – Effects that are no longer available still in the Effect menu, which is a problem for previously shipped effects

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1453 - Effects that are no longer available still in the Effect menu, which is a problem for previously shipped effects


Summary:	Effects that are no longer available still in the Effect menu, which is a pro...

Status:	REOPENED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.1.3
Hardware:	Per OS All

Importance:	P3 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:	test_single_OS, upgraders

Depends on:
Blocks:	1587
	Show dependency tree / graph

Reported:	2016-07-22 11:11 UTC by Gale Andrews
Modified:	2018-08-23 18:12 UTC (History)
CC List:	4 users (show)

See Also:	1942
Steps To Reproduce:	1 For example to reproduce the issue easily on Windows, delete pluginregistry.cfg, install 2.1.0 to %Program Files% and launch 2.1.0. 2 Exit 2.1.0 and install 2.1.2 to the same location. This will remove Hard Limiter from the Plug-Ins folder. Launch 2.1.2. 3 Click Effect > Hard Limiter... and observe the initialization error. 4 Restart 2.1.2 and repeat step 3. Same error occurs. 5 Restart 2.1.2, open Plug-in Manager and observe Hard Limiter is listed as Disabled. Dismiss Plug-in Manager by ESC. 6 Repeat Step 3. The initialization error still occurs. 7 Restart 2.1.2. Finally, Hard Limiter is not in the Effect menu. 8 Now build and run an installer for 2.1.3-alpha, or just run 2.1.3-alpha. Click on Effect > Leveller. The same initialization error will occur.
Release Note:	GROUP: Effects * '''Effects, Generators or Analyzers plug-ins (except Nyquist) that are no longer available remain listed in the menus until you open the [https://manual.audacityteam.org/man/manage_effects_generators_and_analyzers.html Plug-in Manager].''' The plugins will then be removed from the menus after restarting Audacity. This also applies to previously shipped plug-ins that are no longer available in current Audacity, such as Hard Limiter.
First Git SHA:
Group:	---
Workaround:
Closed:

Flags:	gale: Test‑OK‑Win+ gale: Test‑OK‑Mac+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2016-07-22 11:11:32 UTC

Comment 1 James Crook 2017-02-06 11:29:02 UTC

Nyquist (and built-ins) only amelioration.

https://github.com/audacity/audacity/commit/e4260e9581facc288be40d9ca84f98d52ec724b1

The same technique could be extended to other plug-in types, but hasn't been due to the likely slow down at start up of doing so.

Comment 2 Gale Andrews 2017-02-07 02:20:45 UTC

Tests as functional for me on Win 10 and Sierra. Non-existent Nyquist effects that are in pluginregistry.cfg are removed from the menus and retain a disabled entry in Plug-in Manager (limitation of the fix).   

Verified that Leveller is similarly removed from Effect menu and disabled in Plug-in Manager.  

Extra delay on launch arising from having 200 Nyquist plugins is about 10 seconds on my Win 10 HDD 2.4 GHz 6 GB RAM.

Comment 3 James Crook 2017-08-11 06:33:02 UTC

RESOLVED FIXED per testing in comment #2.

Comment 4 James Crook 2017-08-12 15:15:02 UTC

Closed a little too hastily.

This bug has been sufficiently ameliorated for the Nyquist effects, and Leveller, which were the main culprit.

Perhaps the residual deserves a lower rating than P2?

Comment 5 James Crook 2017-08-17 18:19:37 UTC

Demoted to P3.  The main problem, fixed in comment 1, was with Nyquist.