Bug 1464 – Labels Editor: Displayed track names incorrect after removing one of multiple labels in a track

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1464 - Labels Editor: Displayed track names incorrect after removing one of multiple labels in a track


Summary:	Labels Editor: Displayed track names incorrect after removing one of multiple...

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	Labels
Version:	2.1.3
Hardware:	Per OS All

Importance:	P4 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-07-30 13:05 UTC by Gale Andrews
Modified:	2018-08-20 11:51 UTC (History)
CC List:	8 users (show)

See Also:
Steps To Reproduce:	1 New project. Add a label track and add two labels in that track e.g. a label called "1" at 1 second and called "2" at 2 seconds. Name the label track e.g. as "A". 2 Add another label track and a label e.g. called "3" at 3 seconds. Name the label track e.g. as "B". This step is not needed to reproduce the bug but makes it easier to see why it is confusing. 3 Open Tracks > Edit Labels... . Select either label "1" or "2" in Label Track "A" and click "Remove". * Expected if I remove label 1: The first label shows as Track: "1 - A" and Label: "2". The second label shows as Track: "2 - B" and Label: "3". * Actual: The first label shows as Track: "2 - B" and Label: "2" and the second label as Track: "2 - Label Track" and Label: "3". This is confusing because we seem to have lost the first label track and have two different names for the second track. However the flaw is cosmetic because OK on Labels Editor produces the expected result. The same problem occurs if I select Label 1 in the editor, SHIFT + DOWN arrow then click "Remove", given the editor does not support multiple label removal so only removes label 1. Track name does not get wrongly displayed if I remove the sole label in Label Track "B".
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	gale: Accessibility+ gale: Regression+ gale: Test‑OK‑Win+ gale: Test‑OK‑Mac+ gale: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2016-07-30 13:05:25 UTC

Regression on 2.0.0. Not known where it broke - 2.1.0 through 2.1.3-alpha all do the same. 

If David wishes, he could promote to P3 and add a release note in bug 33. However I am guessing that VI users can live with this given the length of time it has gone unreported.

Comment 1 David Bailes 2016-08-01 07:19:24 UTC

(In reply to Gale Andrews from comment #0)
> Regression on 2.0.0. Not known where it broke - 2.1.0 through 2.1.3-alpha
> all do the same. 
> 
> If David wishes, he could promote to P3 and add a release note in bug 33.
> However I am guessing that VI users can live with this given the length of
> time it has gone unreported.

fixed in:
https://github.com/audacity/audacity/commit/0569572d1b29101aed9b23519c3d38069e39bd03

Comment 2 Paul L 2016-08-01 15:19:18 UTC

David reverts a part of commit 5c4ac939db38ff2d31992c9114879c990a987621.  Are we sure there is no regression in the stated purpose of this commit?  (Below)

Author: lllucius <lllucius@47890b92-0858-11df-a26f-8b716316a5bc>  2013-09-24 01:29:37
Committer: lllucius <lllucius@47890b92-0858-11df-a26f-8b716316a5bc>  2013-09-24 01:29:37
Parent: f8a4adf7138878f2561f567fd4ae73dd2853ecd7 (Add volume support for WASAPI.)
Child:  2f89ef9bae53e93fbc51ccbbea672235b0a0b4fc (TAB to the nearest label when the label track has focus.)
Branches: master, remotes/audacity/master and many more (69)
Follows: Audacity-2.0.0
Precedes: Audacity-2.0.6

    Allow blanks labels to be retained when leaving the Label Editor.

Comment 3 David Bailes 2016-08-02 03:57:39 UTC

(In reply to Paul L from comment #2)
> David reverts a part of commit 5c4ac939db38ff2d31992c9114879c990a987621. 
> Are we sure there is no regression in the stated purpose of this commit? 
> (Below)
> 
> Author: lllucius <lllucius@47890b92-0858-11df-a26f-8b716316a5bc>  2013-09-24
> 01:29:37
> Committer: lllucius <lllucius@47890b92-0858-11df-a26f-8b716316a5bc> 
> 2013-09-24 01:29:37
> Parent: f8a4adf7138878f2561f567fd4ae73dd2853ecd7 (Add volume support for
> WASAPI.)
> Child:  2f89ef9bae53e93fbc51ccbbea672235b0a0b4fc (TAB to the nearest label
> when the label track has focus.)
> Branches: master, remotes/audacity/master and many more (69)
> Follows: Audacity-2.0.0
> Precedes: Audacity-2.0.6
> 
>     Allow blanks labels to be retained when leaving the Label Editor.

I've tested that blank labels are still retained.

Comment 4 Peter Sampson 2016-08-02 13:41:32 UTC

Testing on W10 audacity-win-r0569572-2.1.3-alpha-02-aug-16 abd on Mac El Capitan r0569572 02Aug16.

On both platdorms 

a)I get the proper "Exppected result at Step 3 - i.e. the track names are retained properly.

b) blank labels are handled properly

c) as David describes it looks as though you can select multiple labes with the Shif+Down/Up - but the Remove only takes out one label at a time and that is the one that has the black rectangle around it i.e. the initial selection before making the Shift+Down/Up

Comment 5 Gale Andrews 2016-08-06 11:09:51 UTC

It tests OK for me on Ubuntu 14.04. Thanks.