Bug 1473 – Starting scrubbing stops recording without prompt or option

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1473 - Starting scrubbing stops recording without prompt or option


Summary:	Starting scrubbing stops recording without prompt or option

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	Audio IO
Version:	2.1.3
Hardware:	Per OS All

Importance:	P3 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-08-09 01:00 UTC by Gale Andrews
Modified:	2018-08-20 11:51 UTC (History)
CC List:	7 users (show)

See Also:
Steps To Reproduce:	1 Record. 2 Initiate scrubbing by button, shortcut or menu. 3 Recording stops.
Release Note:	GROUP: Scrubbing and Seeking * '''Starting Scrubbing or Seeking is allowed to stop recording without any prompt or option.'''
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	gale: Regression+ petersampsonaudacity: Test‑OK‑Win+ gale: Test‑OK‑Mac+ stevethefiddle: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2016-08-09 01:00:21 UTC

Comment 1 Peter Sampson 2016-08-09 04:05:37 UTC

I believe that P3 is seriously under-rating this bug.

We had a long discussion some while nback about what sjould and should not be allowed to interrupt a recording (or a paused recording) and the definite consensus was that this should only be the Stop button or its shortcut the spacebar. Some of us (Bill and I in particular) even wanted the space bar to not interrupt - but conceded to consensus.

Accidentally interrupting a recording, particularly ann unrepeatable one, is a serious matter potentially causing an irretrievable loss for a user.  We should do all we can to protect users from such loss.

Comment 2 Peter Sampson 2016-08-09 06:29:21 UTC

And note that we totally inhibit any other form of playback, Play itself and Timeline Quick-Play, so we should also be totally inhibiting any attempt to Scrub or Seek while Recording.

Note too that the Record button in the Transport Toolbar is grayed out as inoperable while recording - so the Scrub and Seekk buttons should be similarly grayed out as inoperable while recording


Similarly the Scrubbing entry in the Transport menu should be grayed out and inoperable (or maybe its Scrub and Seek sub-menu items) while recording.


Interestingly, and correctly, access to the Scrub Bar is denied while recording is taking place - so you cannot interrupt a recording by trying to invoke scrubbing or seeking from the Scrub Bar.

Comment 3 Steve Daulton 2016-08-09 09:13:01 UTC

Quick Fix https://github.com/audacity/audacity/commit/6089c9

Comment 4 Peter Sampson 2016-08-09 15:07:05 UTC

(In reply to Steve Daulton from comment #3)
Tested on W10 audacity-win-r8cb8e59-2.1.3-alpha-09-aug-16

When recording is taking place:
a) you cannot invoke scrubbing from the Scrub/Seek buttons'
b) the Scrub & Seek buttons are grayed out,
c) you cannot invoke scrubbing from the Scrub/Seek Transport>Scrubbing menu,
d) the Scrub & Seek menu items in Transport>Scrubbing buttons are grayed out,
e) the Scrub Bar remains out of use.

Looks good (on W10 anyway)

Comment 5 Gale Andrews 2016-08-10 12:23:43 UTC

Given I believe James regards playback stopping recording as not a bug, P3 is an "average" rating/
  
Thanks, Steve for the fix.  

Tests OK on Mac. I also tested using shortcuts to attempt seek or scrub during recording and trying to start seek or scrub in a second project during recording.