Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 1491 - Inno Setup fails to build installer on Windows 10.
Inno Setup fails to build installer on Windows 10.
Status: RESOLVED FIXED
Product: Audacity
Classification: Unclassified
Component: Installer
2.1.3
Per OS Other
: P4 Repeatable
Assigned To: Default Assignee for New Bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-08-21 15:08 UTC by James Crook
Modified: 2018-08-20 11:45 UTC (History)
6 users (show)

See Also:
Steps To Reproduce:
Inno Setup fails to make an installation on Windows 10. 1. Language files (.isl) files are not downloaded/created for Dummy languages. 2. Inno Setup fails to find the resetPrefs task. If these are commented out, Inno Setup runs to completion and produces a less function installer. [Inno Setup Version 5.5.9 non Unicode]
Release Note:
First Git SHA:
Group: ---
Workaround:
Closed: 2018-08-20 00:00:00


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Crook 2016-08-21 15:08:44 UTC
Inno Setup fails to make an installation on Windows 10.

1. Language files (.isl) files are not downloaded/created for Dummy languages.
2. Inno Setup fails to find the resetPrefs task.

If these are commented out, Inno Setup runs to completion and produces a less function installer.
[Inno Setup Version 5.5.9 non Unicode]
Comment 1 Gale Andrews 2016-08-23 12:51:12 UTC
(In reply to James Crook from comment #0)
> Inno Setup fails to make an installation on Windows 10.
> 
> 1. Language files (.isl) files are not downloaded/created for Dummy languages.
> 2. Inno Setup fails to find the resetPrefs task.
> 
> If these are commented out, Inno Setup runs to completion and produces a 
> less function installer. [Inno Setup Version 5.5.9 non Unicode]
I can't reproduce either of those on Windows 10 (Inno 5.5.9 Unicode). Do we need to worry about the ANSI version of Inno?  Our Release Process specifies the Unicode version of Inno http://wiki.audacityteam.org/wiki/Release_Process/Win#Build_the_Installer.

Is Windows PowerShell appearing when you run the installer and it tries to download additional translations? 

If this is a problem on your machine with the Unicode Inno then the failure of Reset Preferences would be P1 in my book.
Comment 2 James Crook 2016-08-23 14:37:44 UTC
My mistake.  I was using the non-unicode.  I will try the unicode version next and report back.  If it works, I'll mark this bug as INVALID.  I used the ANSI version because it seemed to be the most popular; didn't notice the statement to use unicode version.

Powershell was appearing, but (apparently) failing to download the .isls.

The resetPrefs problem was caused by me attempting to solve/diagnose the issue, and commenting out too much.
Comment 3 James Crook 2016-08-29 14:17:01 UTC
Inno Setup had a permission problem writing to the languages/dummy directory. Once that was fixed it got through the dummy .isls.  It didn't have the unofficial isls, but I downloaded them from GitHub.

After that it can package Audacity, with languages.

I notice that if I install in German, even though I am using the Unicode version, umlauts in the installer are shown as character pairs, as if it is the non Unicode version.  (new bug?)

Written up fixes in wiki http://wiki.audacityteam.org/wiki/Release_Process/Win

DEVEL - FIX MADE
Comment 4 James Crook 2017-09-28 11:20:35 UTC
Paul has built the installer on windows 10, so RESOLVED FIXED