Bug 1505 – Window size not restored on launch (using virtual desktop)

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1505 - Window size not restored on launch (using virtual desktop)


Summary:	Window size not restored on launch (using virtual desktop)

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.1.2
Hardware:	Per OS All

Importance:	P4 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-08-30 09:47 UTC by James Crook
Modified:	2018-08-20 11:45 UTC (History)
CC List:	6 users (show)

See Also:	1099
Steps To Reproduce:	1) reduce Widow size to very small 2) Close Audacity 3) relaunch Audacity 4) observe window size
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win- petersampsonaudacity: Test‑OK‑Mac-

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description James Crook 2016-08-30 09:47:49 UTC

Window resizing not remembered between sessions.

Seen with Windows executable.  Happens in 2.1.2.  Does not happen in 2.1.1.  Happens with Dexpot virtual desktop.

Comment 1 James Crook 2016-08-30 17:21:38 UTC

DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/576020f203e692ccddc065268c6607bdc26b0b72

emails with the affected user established that the root of the problem was a project window that was very near the edge.  He was staying on 2.1.1 rather than upgrading to 2.1.2 because of this issue.

Comment 2 Gale Andrews 2016-08-31 11:56:06 UTC

I "think" this is not specific to virtual desktops or Windows but is cross-platform. It was a residual P3/P4 from this fix http://bugzilla.audacityteam.org/show_bug.cgi?id=1243#c19 that never got onto Bugzilla. What it amounted to was that if you dragged any part of the Audacity window even slightly off screen then did File > Close or Exit, the next Audacity window was centred at default size.

Cursory testing suggest this does fix what I describe above, so this wants testing on all platforms.

Comment 3 Peter Sampson 2017-08-03 11:55:53 UTC

(In reply to James Crook from comment #1)
Testing on macOS Sierra 10.12.6 with 53c3adf 03Aug17 3e39771
and on W10 audacity-win-ra45f3bb-2.2.0-alpha-22-jul-17

Window sizes on both platforms appear to be remembered and restored correctly.

Comment 4 Peter Sampson 2017-08-03 12:00:56 UTC

(In reply to Peter Sampson from comment #3)
But NOT SO if you drag the window partly off-screen

So flagged as minus on Mac and Win

and marked the bug as REOPENED

Comment 5 James Crook 2017-08-03 12:15:18 UTC

For Comment #4 to be valid the steps to reproduce would need updating.  They have not been.

The original issue per comment 0 and comment 1 and current steps to reproduce are, per comment 3 fixed.  Comment #2 is a request for a change in behaviour to not fix-up partly off screen windows.  That's wrong.  We should do.  It's almost off screen windows that we should not 'fix up'.

RESOLVED FIXED based on a fix by me and the test by Peter in comment 3.  Comment 4 does not belong in this bug (unless the steps are changed, wherupon I mark the bug as invalid, since it is a request for a change in behaviour and not an actual bug).