Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 1537 - Some commands may be incorrectly enabled by "Select all on none" Preference
Some commands may be incorrectly enabled by "Select all on none" Preference
Status: RESOLVED QUICKFIXED
Product: Audacity
Classification: Unclassified
Component: User Interface
unspecified
Per OS All
: P4 Repeatable
Assigned To: Default Assignee for New Bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-10-27 13:03 UTC by Steve Daulton
Modified: 2018-08-20 11:51 UTC (History)
6 users (show)

See Also:
Steps To Reproduce:
Release Note:
First Git SHA:
Group: ---
Workaround:
Closed: 2018-08-20 00:00:00
petersampsonaudacity: Test‑OK‑Win+
petersampsonaudacity: Test‑OK‑Mac+
stevethefiddle: Test‑OK‑Lin+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Daulton 2016-10-27 13:03:53 UTC
Commands including:
* Export Selection
* Trim
* Split
* Split New
* Split Delete
should (according to the code), be disabled when there is no audio track selection. This (according to the code) should not be overridden by the preference "Select all if none selected".

If the cursor is in a label track (only), with no time selection, the "Select all when none selected" setting incorrectly overrides the designed behaviour.

The original purpose of the "Select all if none" behaviour was to mitigate complaints from new users that were confused by greyed out menus when no audio was selected.

Subject to discussion, my preferred solution would be to not implement the "Select all..." behaviour for any Edit or File commands, but rather to devise a non-intrusive means to educate users about the use of audio selections.

As a less radical solution, the logic errors controlling the behaviour needs to be corrected.
Comment 1 Steve Daulton 2016-10-27 19:55:48 UTC
Fixed with https://github.com/audacity/audacity/commit/b5ccd5b

The behaviour now matches the code description, and the behaviour of Edit button should now match the behaviour of their Menu counterparts (residual from bug 1536).
Comment 2 Peter Sampson 2016-11-01 10:01:27 UTC
(In reply to Steve Daulton from comment #1)
Testing on audacity-win-rccbee2b-2.1.3-alpha-31-oct-16
and on Mac Sierra ccbee2 31Oct16

Th commands that Steve lists in his original bug report are now properly grayed-out and inoperable when there is no selction made even if the prefernce for "Select all ..." is set to "on".


However Edit>Remove Special>Silence Audio is not grayed it - both it and its shortcut Ctrl+L/Ctrl+L work to silence the entire audio - but I think this is proabably expected behavior.

Looks to be fixed.
Comment 3 Gale Andrews 2016-12-01 19:35:25 UTC
(In reply to Peter Sampson from comment #2)
> Th commands that Steve lists in his original bug report are now properly
> grayed-out and inoperable when there is no selction made even if the 
> prefernce for "Select all ..." is set to "on".
Steve did not mean to suggest that Split should be disabled when there is no time selection, so as before, Split is still enabled as long as a track is selected (click in the background to disable it).