Bugzilla – Bug 1541
Skip to Start/End buttons don't show that they respect SHIFT usage
Last modified: 2018-08-20 11:51:33 UTC
The two Skip buttons in the Transport Toolbar do not behave consistently with the other buttons in that toolbar that can be modified with the Shift key, the Play button and the Record button: a) When Shift is held down there is a visual cue that the Play and Record buttons exhibit Shift-modified behaviour as their inconography changes appropriately. This does not happen with either of the Skip buttons. b) When hovering over the Play and Record buttons the tooltips show the unmodified behaviour and the Shift-modified behaviour. This is not the case for either of the Skip buttons where only the normal unmodified behaviour is shown.
(In reply to Peter Sampson from comment #0) Gale commented by email: The tooltips should read by default: "Skip to Start (Home) / Selection to Start (Shift + Home)" "Skip to End (End) / Selection to End (Shift + End)". Wording then matches with that in Keyboard Preferences. I don't know what a suitable icon for SHIFT-modified Skip buttons would be. Suggestions?
Thanks for adding the bug. Made the title shorter.
DEVEL - FIX MADE https://github.com/audacity/audacity/commit/b196c7de8dff792f8f8ad848e64be4e6c49a292f Also for Play-at-speed. Note that the buttons show the SHIFT+J SHIFT+K shortcuts, not the SHIFT+Home SHIFT+End ones.
(In reply to James Crook from comment #3) > Note that the buttons show the SHIFT+J SHIFT+K shortcuts, not the SHIFT+Home > SHIFT+End ones. Would that not lead to the fix being rejected? 1 Create a 20 seconds track (#1) 2 Create a 5 seconds track (#2) 3 F5, shift track #2 to start at 5s, F1, click at about 8s in this track. 4 Shift + J, which selects from 5s to 8s. Click at 8s in track #2. Shift-click Skip to Start button. It selects 0s to 8s (different behaviour than the shortcut seen in the tooltip). 5 Click at about 8s in track #2. Shift + K, which selects from 8s to 10s. Click at 8s in track #2. Shift-click Skip to End button. It selects 8s to 20s (different behaviour than the shortcut seen in the tooltip).
(In reply to Gale Andrews from comment #4) James wrote: >> Note that the buttons show the SHIFT+J SHIFT+K shortcuts, not the SHIFT+Home >> SHIFT+End ones. > Would that not lead to the fix being rejected? I see no response here or on the -quality list, so REOPENED.
DEVEL - FIX MADE https://github.com/audacity/audacity/commit/97cdd3194891e1b5fd95e4c9ec6e36ff9427dcf9
Thanks for correcting the fix.
