Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 1550 - Metadata editor: pressing Esc does not cancel the dialog
Metadata editor: pressing Esc does not cancel the dialog
Status: RESOLVED QUICKFIXED
Product: Audacity
Classification: Unclassified
Component: User Interface
2.1.3
Per OS Windows (all)
: P3 Repeatable
Assigned To: Default Assignee for New Bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-11-28 07:03 UTC by David Bailes
Modified: 2018-08-20 11:51 UTC (History)
7 users (show)

See Also:
Steps To Reproduce:
Release Note:
GROUP: Imports and Exports * (Windows) '''Metadata Editor cannot be dismissed with ESC,''' whatever control has focus. '''Workaround:''' hold ALT and press F4.
First Git SHA:
Group: ---
Workaround:
Closed: 2018-08-20 00:00:00
james.k.crook: Test‑OK‑Win+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Bailes 2016-11-28 07:03:58 UTC
When the grid is the focus, pressing ESC does not cancel the dialog.

Work around: press shift+tab to move to the cancel button and press it.
Comment 1 David Bailes 2016-11-28 08:38:32 UTC
(In reply to David Bailes from comment #0)
> When the grid is the focus, pressing ESC does not cancel the dialog.
> 
> Work around: press shift+tab to move to the cancel button and press it.

This was caused by:
https://github.com/audacity/audacity/commit/c1ca055fa4fc42b382874de40f2d72f46becd92b

which was committed to fix bug 1273:
http://bugzilla.audacityteam.org/show_bug.cgi?id=1273
Comment 2 David Bailes 2016-11-28 09:10:28 UTC
Changed the title of the bug since I've since discovered that whatever control is the focus, pressing Esc does not cancel the dialog.

Work around: tab to the cancel button and press it, and using (shift + )ctrl + tab to get quickly out of the grid if necessary.
Comment 3 David Bailes 2016-11-28 09:19:22 UTC
(In reply to David Bailes from comment #2)
> Changed the title of the bug since I've since discovered that whatever
> control is the focus, pressing Esc does not cancel the dialog.
> 
> Work around: tab to the cancel button and press it, and using (shift + )ctrl
> + tab to get quickly out of the grid if necessary.

Quicker work around is just to press alt + f4.
Comment 4 Gale Andrews 2016-11-30 18:50:31 UTC
Added release note as David would like P3.

On iTunes on Mac Sierra, ESC when focus is in the tags grid and the cell closed (or anywhere else) dismisses the dialogue. If the grid cell is open, the first ESC closes the cell then the next ESC dismisses the dialogue. Isn't that the behavior we want for Metadata Editor and Labels Editor on all platforms? Labels Editor still follows those guidelines on Windows.
Comment 5 David Bailes 2016-12-01 03:47:37 UTC
(In reply to Gale Andrews from comment #4)
> Added release note as David would like P3.

thanks.

> 
> On iTunes on Mac Sierra, ESC when focus is in the tags grid and the cell
> closed (or anywhere else) dismisses the dialogue. If the grid cell is open,
> the first ESC closes the cell then the next ESC dismisses the dialogue.
> Isn't that the behavior we want for Metadata Editor and Labels Editor on all
> platforms?

Yes.

>Labels Editor still follows those guidelines on Windows.
Comment 7 Peter Sampson 2017-02-25 08:06:12 UTC
Testing on W10 audacity-win-r0a0a9f6-2.1.3-alpha-25-feb-17

Esc dismisses the Metadata Editor - tested with focus on all the controls and on the table entries.

Looks to be fixed