Bugzilla – Bug 1550
Metadata editor: pressing Esc does not cancel the dialog
Last modified: 2018-08-20 11:51:24 UTC
When the grid is the focus, pressing ESC does not cancel the dialog. Work around: press shift+tab to move to the cancel button and press it.
(In reply to David Bailes from comment #0) > When the grid is the focus, pressing ESC does not cancel the dialog. > > Work around: press shift+tab to move to the cancel button and press it. This was caused by: https://github.com/audacity/audacity/commit/c1ca055fa4fc42b382874de40f2d72f46becd92b which was committed to fix bug 1273: http://bugzilla.audacityteam.org/show_bug.cgi?id=1273
Changed the title of the bug since I've since discovered that whatever control is the focus, pressing Esc does not cancel the dialog. Work around: tab to the cancel button and press it, and using (shift + )ctrl + tab to get quickly out of the grid if necessary.
(In reply to David Bailes from comment #2) > Changed the title of the bug since I've since discovered that whatever > control is the focus, pressing Esc does not cancel the dialog. > > Work around: tab to the cancel button and press it, and using (shift + )ctrl > + tab to get quickly out of the grid if necessary. Quicker work around is just to press alt + f4.
Added release note as David would like P3. On iTunes on Mac Sierra, ESC when focus is in the tags grid and the cell closed (or anywhere else) dismisses the dialogue. If the grid cell is open, the first ESC closes the cell then the next ESC dismisses the dialogue. Isn't that the behavior we want for Metadata Editor and Labels Editor on all platforms? Labels Editor still follows those guidelines on Windows.
(In reply to Gale Andrews from comment #4) > Added release note as David would like P3. thanks. > > On iTunes on Mac Sierra, ESC when focus is in the tags grid and the cell > closed (or anywhere else) dismisses the dialogue. If the grid cell is open, > the first ESC closes the cell then the next ESC dismisses the dialogue. > Isn't that the behavior we want for Metadata Editor and Labels Editor on all > platforms? Yes. >Labels Editor still follows those guidelines on Windows.
DEVEL-FIXMADE https://github.com/audacity/audacity/commit/06dc9073ab35e939dbcae1f578df3d0aea427ceb
Testing on W10 audacity-win-r0a0a9f6-2.1.3-alpha-25-feb-17 Esc dismisses the Metadata Editor - tested with focus on all the controls and on the table entries. Looks to be fixed