Bug 1564 – Enh: Don't include empty tooldocks in CTRL + (SHIFT +) F6 cycling

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1564 - Enh: Don't include empty tooldocks in CTRL + (SHIFT +) F6 cycling


Summary:	Enh: Don't include empty tooldocks in CTRL + (SHIFT +) F6 cycling

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.1.3
Hardware:	Per OS Windows and Linux

Importance:	P4 Enhancement
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-12-21 13:33 UTC by Gale Andrews
Modified:	2018-08-20 11:51 UTC (History)
CC List:	7 users (show)

See Also:
Steps To Reproduce:	1 Float all the toolbars out of the upper and lower tooldock areas. 2 CTRL + F6. The empty tooldocks are still included in the cycling.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2016-12-21 13:33:57 UTC

This already works on Mac, so this enh would give platform consistency. David Bailes would be OK with this change - see final comments for bug 1252.

Comment 1 James Crook 2017-08-17 07:44:29 UTC

DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/50258c1f2128e6ed2d929891a616fb99bdfa4700

To test on all three platforms.

Comment 2 Peter Sampson 2017-10-12 09:06:48 UTC

I'm finding this impossible to test as I can't for the life of me see what Ctrl + F6 does on either Windows or Mac.

Maybe David could illuminate and explain.

Comment 3 David Bailes 2017-10-12 12:47:03 UTC

(In reply to Peter Sampson from comment #2)
> I'm finding this impossible to test as I can't for the life of me see what
> Ctrl + F6 does on either Windows or Mac.
> 
> Maybe David could illuminate and explain.

http://manual.audacityteam.org/man/keyboard_shortcut_reference.html#focus

So immediately after opening Audacity, the focus is the track area. Pressing ctrl+f6 moves the focus to the project rate, and pressing ctrl+f6 moves the focus to the pause button, etc.

Comment 4 Peter Sampson 2017-11-08 08:50:44 UTC

Testing om macOS 10.13.1 High Sierra and on W10 Audacity2.2.1JC5Nov2017

This now works OK on W10 and still works on Mac as Per Gale's Comment #0

Accordingly I shall mark this RESOLVED