Bugzilla – Bug 1600
(Mac) Export Multiple progress dialogs behind the main Export Multiple dialog
Last modified: 2018-08-20 11:46:04 UTC
For each file of the multiple export a progress dialog is put up with the name of the file as the title of the dialog. Once the first file has finished exporting, that dialog is removed and a new one is put up. Unfortunately this second dialog is _behind_ the Export Multiple dialog.
Tried: pWin->Iconize(false); pWin->SetFocus(); pWin->Raise(); pWin->Show(true); But that didn't work. Only the first progress dialog is in front :-(
Regression on 2.1.1. Added Release Note given it's P3. Just to say I did have one Forum user report (El Capitan) of this, using Export Multiple by labels, but I had failed to reproduce it reliably on Yosemite, El Capitan or Sierra. About one time in 20, I saw it happen, apparently randomly. Now I see Bill mentions that he turns off "Show Metadata Tags..." in Import / Export Preferences. That for me makes the issue much more reproducible, but not fully. The Forum user's experience was different. He said that reliably, the progress dialogue failed to appear only for the export corresponding to where the cursor was, otherwise it appeared. I can't reproduce that. I have tried moving or not moving the mouse during Export Multiple but it doesn't affect reproducibility for me.
Just tested again on Sierra. Was able to eventually bring the progress dialog to the front with CMD+` (Apple switch task within an app), BUT the Cancel and Stop buttons do not function. Mouse click, Enter, ESC nothing will kill that process. Canceled the large Export dialog, but it did not cancel the export process, just left the "Beach Ball" spinning (By design?). Even CMD+Q would not close Audacity until the export was finished (By design?). Did not try force quit. At least the Cancel-Stop buttons should work on the individual file progress dialogs. Should this should be a separate bug from the hidden progress dialog?
Hidden progress problem happens 100% reliably for me on El Capitan. Second and subsequent progress dialogs are behind Audacity window, not just behind the Export-Multiple dialog.
Noticed the progress window behind Audacity window as well on Sierra. Also noticed that the apparent reason the Cancel & Stop buttons don't work is that the dialog isn't active, for lack of a better word. In other words it isn't setup to receive input as indicated by neither of the buttons is blue as they are in other dialogs when the dialog can receive input.
I've also tried adding code that guarantees the progress dialog has the ExportMultiple dialog as its parent (it does not otherwise). I've also tried disabling the initial transparency. Neither worked. I do now get the progress dialog appearing over Audacity and under ExportMultiple dialog (which definitely is its parent) now.
More playing with Export Multiple. The Stop & Cancel buttons work on the progress dialog for the first file exported. After that it causes a variety of issues. One issue is that Audacity RC2 cannot be closed or quit in some cases of clicking Close or Quit. Also noted that at least in one case there were 2 dialogs going at the same time on different files. The dialogs were on top of each other so only can see this if the top one is drug off the other one. Moral of the story, at this point, don't mess once it is on file number 2.
Comment#7 chimes with something I've suspected. Two progress dialogs at the same time are bad news. That's likely causing a problem with wxWindowDisabler. Two progress dialogs at the same time probably does not happen with Windows. Can be checked by adding some more log/debug messages. However, unless Gale promotes this to P2 in the light of the recent findings, I am unlikely to investigate further for 2.1.3 RC3.
James wrote in Comment #8 >Comment#7 chimes with something I've suspected. Two progress dialogs >at the same time are bad news. In which casew this may be a good opportunity to tidt up the Export Multiple GUI. I've always thought the the secondary dialog as eah labelled section is exported is inelegant an clumsy. I would much prefere to see progress indicated on the dialog that intitates the multiple export. Or on invokeking the exports, slose the setupup dialog and hand over to a progress dialog (as we do with Timer Record). Apart from any other consideration the text in the mini dialog as we expoert each label defined piece of audio is totally inaccurate as is says: "Exporting the entire project ..." a) this is not true with point labels unless the initial label is at T=0 b) and for a project with range labels only the parts of the project with ranges so defined is exported. We either need a single progrees bar as the mutiple exports proceed or if we continue to advise which label delineated chunk is being deleted we should say which chunk is being deleted (i.e. as defined by the label name)
(In reply to Peter Sampson from comment #9) OOPS - export NOT delete ... >We either need a single progrees bar as the mutiple exports proceed >or if we continue to advise which label delineated chunk is being >exported we should say which chunk is being exported (i.e. as defined >by the label name)
I looked a bit at this. I think that this may be a wxWidgets 3 and Mac thing only, involving the interaction of wxWindowDisabler with an existing modal dialog. It seems you can create and destroy a wxWindowDisabler only once with the correct effects. If I make no wxWindowDisabler at all in ProgressDialog, then all progress dialogs are hidden. I think a solution could involve recycling of ProgressDialog objects, so that there is only one object for the duraction of the ExportMultiple, but it can appear and disappear and change its text. This is more work than I want to do in 2.2.1.
(In reply to Paul L from comment #11) >This is more work than I want to do in 2.2.1 Cliff was only flagging up this for attention in 2.1.2 (or wahtever subsequent release is) not 2.2.1
I'm sure Peter meant to say 2.2.2 or subsequent. IMO, the earlier the better for the Audacity reputation.
It looks like this bug may be impacting the testing of Bug #1831 See:http://bugzilla.audacityteam.org/show_bug.cgi?id=1831#c5 As it appears that bot only are these progress dialogs "hidden" - when you do make them visible by sliding the Audacity window and the Export Multiple dialog around - then you find that the Stop and Cancel buttons in the progress dialog are not operable.
Try this out: https://github.com/audacity/audacity/commit/d4b21bb33e54ef7b568dd165040adb4dcbb1bbb8 Be sure nothing goes wrong on Windows either.
(In reply to Paul L from comment #15) Testing on macOS 10.13.2 High Sierra with audacity-macos-nightly-2.2.2-60ea8a6.dmg - 27.48 MB | version: 2.2.2--26Jan18 This now works correctly with all the progress dialogs top-showing and no longer hidden behind the main Export Multiple dialog And this fix does indeed facilitate testing of Bug #1831
