Bug 1603 – (mac) AUNBandEQ crashes Audacity

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1603 - (mac) AUNBandEQ crashes Audacity


Summary:	(mac) AUNBandEQ crashes Audacity

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	Audio Units
Version:	2.1.3
Hardware:	Per OS macOS

Importance:	P2 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:	665
	Show dependency tree / graph

Reported:	2017-03-06 20:48 UTC by Gale Andrews
Modified:	2018-08-20 11:51 UTC (History)
CC List:	7 users (show)

See Also:
Steps To Reproduce:	1 Open AUNBandEQ. 2 Spinning beach ball then Audacity quits. See attached stack trace.
Release Note:	// See bug 665
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	gale: Regression+

Attachments
stack trace (48.24 KB, text/plain) 2017-03-06 20:50 UTC, Gale Andrews	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2017-03-06 20:48:51 UTC

Regression on 2.1.1.

Comment 1 Gale Andrews 2017-03-06 20:50:30 UTC

Created attachment 722 [details]
stack trace

Comment 2 Paul L 2017-07-18 03:06:18 UTC

I did not succeed in reproduing this on macOS 10.11.6, running the 2.1.3 release, or running builds of my own, either debug or release, at Audacity-2.1.3

The supplied strack trace looks like an overflow because resizing somehow makes an infinite recursion.

Comment 3 Paul L 2017-07-22 23:00:41 UTC

This is a guess at a fix from the stack trace data.  My mac (at 10.11.6) did not reproduce the problem, and I don't know what system details might account for that.  Someone else should clearly compare before and after this commit to verify the fix.

https://github.com/audacity/audacity/commit/f1aa9161f05278065ec39d94503c9f290eca43f1

Comment 4 Peter Sampson 2017-07-23 11:37:31 UTC

(In reply to Paul L from comment #3)
Testing on macOS Sierra 10.12.5 with Cliff's nightly build of 22Jul17

I enanabled the AUNBandEQ effect and then opened it to apply to some audio.

No spinning beachball-of-death - but instead now the effect dialog appears - and looks to be working.

I will therefore close this bug as resolved/quickfixed

Comment 5 Paul L 2017-07-23 16:31:38 UTC

(In reply to Peter Sampson from comment #4)

Not so fast:  as I said, I could not get the crash on my system without the fix, but guessed at a fix for Gale's from the stack trace he supplied.

To close this honestly requires a before-and-after demonstration of problem and problem solved.

Comment 6 Peter Sampson 2017-07-24 07:38:48 UTC

(In reply to Paul L from comment #5)
Well I get the spinning beachball-of-death (and Audacity crash) consistently on 2.1.2 on my Mac when trying to use AUNBandEQ - but with Cliff's 22 July build I consistently do not.

You may have problems getting Gale to do a re-test on his Mac kit as he is not able to perform testing right now (as he stated elsewhere)

Comment 7 Paul L 2017-07-24 12:43:42 UTC

2.1.2?  I'd like to hear that you got the crash in 2.1.3, to be more confident it's the same crash.

Comment 8 Peter Sampson 2017-07-24 13:39:39 UTC

(In reply to Paul L from comment #7)
I still get the spinnining beachball-of-death when trying to use AUNBandEQ on 2.1.3

Comment 9 Paul L 2017-07-24 15:56:16 UTC

(In reply to Peter Sampson from comment #8)

In that case, I agree that this merits closing.

For the record, record in these comments what your OS version is.  A difference might explain why I could not reproduce the crash.

Comment 10 Peter Sampson 2017-07-24 17:54:32 UTC

For the record I stated in Comment #4 what my OS is