Bug 1608 – LV2 Chain problems: LV2s crash when used in Chains

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1608 - LV2 Chain problems: LV2s crash when used in Chains


Summary:	LV2 Chain problems: LV2s crash when used in Chains

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	LV2
Version:	2.1.3
Hardware:	Per OS All

Importance:	P2 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-03-17 00:00 UTC by Gale Andrews
Modified:	2018-08-20 11:45 UTC (History)
CC List:	7 users (show)

See Also:	1708 1709
Steps To Reproduce:	1 Exit Audacity and delete pluginregistry.cfg. 2 Restart Audacity, install and enable MDA LV2's and/or the LV2 swh-plugins. If you install and enable the LV2 swh-plugins, do not install/enable the LADSPA swh-plugins yet. On Mac you can find MDA and swh LV2's at http://audacity.homerow.net/index.php?dir=lv2%2F. 3 File > Edit Chains... . Add a new chain and click "Insert". Select an MDA or swh LV2 plugin and click "Edit Parameters". Tweak the settings or not, it doesn't matter. On clicking OK or Cancel in the settings window, Audacity will crash.
Release Note:	GROUP: Effects (LV2) * '''Many LV2 plug-ins can only be used in Chains at default parameters.''' Attempting to edit the parameters in the Edit Chains > Select Command window may crash Audacity. MDA and swh LV2s are among those affected.
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	billwh: Test‑OK‑Mac+

Attachments
Stack traces on Mac (31.93 KB, text/plain) 2017-03-17 00:03 UTC, Gale Andrews	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2017-03-17 00:00:03 UTC

Not related to user's locale.

Not a regression on 2.1.2 AFAICT. 

Not testable on Windows due to issues loading LV2s but platform assumed to be "all".

Outside the MDA and swh LV2's, not all LV2 plugins crash for me when editing Chain Parameters on Ubuntu 14.04. Auto-Wah LV2 crashes, but CALF do not.

Comment 1 Gale Andrews 2017-03-17 00:03:59 UTC

Created attachment 724 [details]
Stack traces on Mac

Stack traces on Mac.

A) After attempting to Edit Parameters in a Chain
B) After applying an MDA VST in a Chain at default parameters.

Comment 2 Paul L 2017-08-01 11:41:18 UTC

Separated bug 1708 from this report.

Comment 3 Paul L 2017-08-01 11:49:39 UTC

Separated bug 1709 from this report.  That bug is not a crash so I made it only P3.

Comment 4 Paul L 2017-08-01 12:27:22 UTC

Fixed the remaining crash problem that I did not separate into other bug reports.  Here:  https://github.com/audacity/audacity/commit/560a1e88ed10c7e36f100a0b24e43decfcdbccf4

Comment 5 Bill Wharrie 2017-08-29 10:37:38 UTC

Mac 10.11.4 Audacity 2.2.0-alpha Aug 28
No crash when putting the swh AM Pitchshifter LV2 effect into a chain and editing parameters.
Can't test MDA - seems to be Linux only?

Comment 6 Bill Wharrie 2017-08-29 17:21:25 UTC

Changed title from:
LV2 Chain problems: LV2s crash when used in Chains, or are unavailable in Chains if the LADSPA version is also enabled

to:
LV2 Chain problems: LV2s crash when used in Chains

since "are unavailable in Chains if the LADSPA version is also enabled" is covered in bug 1709.

Don't know if testing is required on other platforms, so not yet Resolved.

Comment 7 James Crook 2017-08-29 17:36:21 UTC

My reading of the code to fix the issue in comment #4 is that it is platform agnostic.  Therefore that the fix for the crash bug only needed testing on one platform.  Therefore RESOLVED FIXED.