Bug 1642 – (Windows) Adding a shortcut or toggling Extra Menus causes ENTER on dropdown to open new project

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1642 - (Windows) Adding a shortcut or toggling Extra Menus causes ENTER on dropdown to open new project


Summary:	(Windows) Adding a shortcut or toggling Extra Menus causes ENTER on dropdown ...

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.2.0
Hardware:	Per OS Windows (all)

Importance:	P4 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-05-06 22:34 UTC by Gale Andrews
Modified:	2018-08-20 11:45 UTC (History)
CC List:	5 users (show)

See Also:
Steps To Reproduce:	1 Launch Audacity on a clean audacity.cfg. 2 Navigate using Ctrl + F6 to a dropdown in a docked toolbar, e.g. Snap To or Audio Host. 3 Alt + Up or Alt + Down to open the menu, select an item, then Return or NUMPAD_RETURN to close the menu. This works fine. 4 Return or NUMPAD_RETURN again on the focused dropdown. Nothing happens, as probably wanted. 5 Enable View > Extra Menus, OR add a new shortcut in Keyboard Preferences (it doesn't matter what shortcut you choose). 6 Repeat Steps 2 and 3, which are still fine. 7 Repeat Step 4. This now opens a new project window. 8 Restart Audacity (don't delete audacity.cfg). Repeat Steps 2, 3 and 4. Step 4 does not reproduce. 9 Turn off Extra Menus, OR add a new shortcut. Steps 2 and 3 work as intended. Step 4 now opens a new project window.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	gale: Regression+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2017-05-06 22:34:17 UTC

Windows only. Regression on 2.1.1.

Comment 1 James Crook 2017-05-15 18:32:42 UTC

DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/eaec68a0146c8506956f270f34d952425b83dab3

This also fixed an apparently more serious bug, where we start our menus at 0 rather than at 17000 when we recreate the menus.  THAT bug could perhaps have been behind some past weirdness on Linux with menus and accelerators.

The kind of thing that could go wrong with this fix is menu items not responding, since on Windows I now disallow menu items below 17000.  We shouldn't have any such, but if we relied on that in the past that now won't work.  Didn't see any such problem in my brief testing of this fix.

Comment 2 Peter Sampson 2017-09-04 12:30:07 UTC

Testing on W10 Beta 02Sep17

I do now not get the new project Window as in Step 7
Instead it does nothing (which is presumably required behavior)

And all is fine after restarting Audacity (step 8)

And step 10 with turning off the extra menus and the retesting also does not result in a new project window.

So lppks to be fixed on W10 - and as this is Windows-only I shall close this as RESOLVED