Bugzilla – Bug 1648
Crash clicking Help icon in Spectrograms Settings
Last modified: 2018-08-20 11:51:50 UTC
Reproduced on Win 10 and Ubuntu 14.04 so presumed "all". gdb backtrace from release build provided below for information. Program received signal SIGSEGV, Segmentation fault. PrefsDialog::OnHelp (this=0xbfffd928) at prefs/PrefsDialog.cpp:399 399 PrefsPanel* panel = static_cast<PrefsPanel*>(mCategories->GetCurrentPage()); (gdb) bt #0 PrefsDialog::OnHelp (this=0xbfffd928) at prefs/PrefsDialog.cpp:399 #1 0xb74b42f6 in wxAppConsoleBase::HandleEvent(wxEvtHandler*, void (wxEvtHandler::*)(wxEvent&), wxEvent&) const () from /home/gale/wxWidgets-3.0.2/lib/libwx_baseu-3.0.so.0 #2 0xb74b471b in wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const () from /home/gale/wxWidgets-3.0.2/lib/libwx_baseu-3.0.so.0 #3 0xb763d46a in wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&) () from /home/gale/wxWidgets-3.0.2/lib/libwx_baseu-3.0.so.0 #4 0xb763d52a in wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*) () from /home/gale/wxWidgets-3.0.2/lib/libwx_baseu-3.0.so.0 #5 0xb763d8f3 in wxEvtHandler::TryHereOnly(wxEvent&) () from /home/gale/wxWidgets-3.0.2/lib/libwx_baseu-3.0.so.0 #6 0xb763d974 in wxEvtHandler::ProcessEventLocally(wxEvent&) () from /home/gale/wxWidgets-3.0.2/lib/libwx_baseu-3.0.so.0 #7 0xb763d9d5 in wxEvtHandler::ProcessEvent(wxEvent&) () from /home/gale/wxWidgets-3.0.2/lib/libwx_baseu-3.0.so.0 #8 0xb7a455cf in wxWindowBase::TryAfter(wxEvent&) () from /home/gale/wxWidgets-3.0.2/lib/libwx_gtk2u_core-3.0.so.0 #9 0xb763da8d in wxEvtHandler::ProcessEvent(wxEvent&) () from /home/gale/wxWidgets-3.0.2/lib/libwx_baseu-3.0.so.0 #10 0xb763d734 in wxEvtHandler::SafelyProcessEvent(wxEvent&) ()
DEVEL - FIX MADE https://github.com/audacity/audacity/commit/4e187d0ce0ce436a11b77c6e431e41c185e39563 I marked this 'test_single_OS' as the bug was at the level of a typo - Audacity was following a null pointer. The fix is simple and very local in effect, not likely to have unexpected repercussions. This is a typical 'QUICKFIX' (I hope!).
I don't know where this Help button is targetting in the Manual (no nightly availabe yet to test) - but it made me realize that we had an omission in not describing the per-track settings RCP dropdown command on the ASpectrogram View page: http://alphamanual.audacityteam.org/man/Spectrogram_View I have placed a P1 there to address that - and once I have completed that it is likely to be a much better target for the Help button in the Specttrogram View TCP command for Spectrogram Settings...
(In reply to Peter Sampson from comment #2) I have added a new H2 section on per-track settings on: http://alphamanual.audacityteam.org/man/Spectrogram_View#spectrogram_settings I think this will be the best/better, certainly preferred, target for the Spectrogram TCP>Spectrogram Settings>Help button.
I was not able to reproduce the crash on Xubuntu 16.04, but I see the potential problem that would account for the crash and which James fixed, and the fixed version works fine here.
(In reply to Steve Daulton from comment #4) Retested with commit 01f853f174e43e5d6 (before James fixed it), and can now reproduce the crash and confirm that https://github.com/audacity/audacity/commit/4e187d0ce0c fixes it.
Tested OK on Mac since I was in that dialog anyway.
