Bug 1652 – (Mac) The Ctrl modifier in keyboard shortcuts is not displayed in the menus, but does function.

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1652 - (Mac) The Ctrl modifier in keyboard shortcuts is not displayed in the menus, but does function.


Summary:	(Mac) The Ctrl modifier in keyboard shortcuts is not displayed in the menus, ...

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.2.0
Hardware:	Per OS macOS

Importance:	P3 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-05-26 23:38 UTC by Cliff Scott
Modified:	2018-08-20 11:46 UTC (History)
CC List:	9 users (show)

See Also:
Steps To Reproduce:	1. Open Audacity Preferences and select Keyboard 2. Setup the keyboard shortcut for the Normalize effect as Control+N. 3. Click OK to close Preferences. 4. Go to the Effects>Audacity menu and see for the Normalize effect that only the letter N is displayed after the Normalize effect rather than ^N. 5. Use the keyboard shortcut and it does work, but just isn't displayed correctly in the menu.
Release Note:	GROUP: Interface * (MacOS) '''The Ctrl modifier for keyboard shortcuts will not display in the menus.''' Only the Key will display, for example with the shortcut Ctrl+N only the letter N will display when it should be ^N. The keyboard shortcut still functions correctly.
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	gale: Regression+ petersampsonaudacity: Test‑OK‑Mac+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Cliff Scott 2017-05-26 23:38:25 UTC

On MacOS, when using the Control modifier in Keyboard shortcuts, the modifier is not displayed in the corresponding menu though the shortcut does function properly. For instance in the menus Control+N should display as ^N, but in fact it displays as N (with no modifier). The Option modifier does display correctly.

This is a regression that appeared with Audacity 2.1.2.

Comment 1 Paul L 2017-07-21 17:44:44 UTC

Thanks for the report, Cliff!

I have fixed it here, and also, made the ^ charater appear in tooltips for toolbar
buttons when they are assigned a keystroke including Control (but that is not so for
any default key binding).

https://github.com/audacity/audacity/commit/3218351a796b513133fc477aa1802f2bcbf0ce9e

Comment 2 Cliff Scott 2017-07-22 00:20:36 UTC

Paul,

Tested and it displays properly, BUT if there already existed shortcuts with  control+? they are converted to Cmd+?. That caused, for me, a bunch of duplicate shortcuts using Cmd modifier. If I went and reassigned the shortcuts then they displayed correctly. The gotcha is for anyone with existing Ctrl+ shortcuts on Mac. 

I would say this is not completely fixed and maybe worse than not displaying them.

Comment 3 Peter Sampson 2017-07-22 12:32:05 UTC

Testing on macOS Sierra 10.12.5 with Cliff's 21Jul17

Displays correctly as "^N" in Prefs>Keyboard.

I have not closed/resolved this in the light of Paul's Comment #2

Comment 4 Paul L 2017-07-22 15:07:32 UTC

(In reply to Cliff Scott from comment #2)

Cliff, I tried what you describe, and I did not see a duplication of shortcuts by name, but I did see that old shortcuts with Control had it remapped to Command.

Or maybe that's what you meant:  your Command and Control shortcuts collided.

This should fix that.

https://github.com/audacity/audacity/commit/31be7949068fb49f5c9b6743f35c936b33eafbcb

Comment 5 Cliff Scott 2017-07-22 15:37:00 UTC

Yes, Paul that is what I meant, i.e. Ctrl+N became CMD+N which already was used.

Tested and it seems good. Can not duplicate the problem so as far as I am concerned the bug can be closed. Thanks Paul for the quick fix.

Comment 6 Peter Sampson 2017-07-23 11:39:53 UTC

In the light of Cliff;s comments - and my successful tests I will close this bug as resolved