Bug 1654 – Enh: Analyze Contrast and Plot Spectrum don't have the new "Help" button

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1654 - Enh: Analyze Contrast and Plot Spectrum don't have the new "Help" button


Summary:	Enh: Analyze Contrast and Plot Spectrum don't have the new "Help" button

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.2.0
Hardware:	Per OS All

Importance:	P4 Enhancement
Assigned To:	Steve Daulton

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-06-06 10:26 UTC by Peter Sampson
Modified:	2018-08-20 11:51 UTC (History)
CC List:	7 users (show)

See Also:
Steps To Reproduce:	A1. select some audio A2. Analyze > Contrast A3. note the alpha text "Help" button B1. select some audio B2. Analyze > Plot Spectrum B3. note that there is no help button at all.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Mac+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Sampson 2017-06-06 10:26:50 UTC

All other Effects Generators and Analyzers are now usin the iconic "?" help button - for consistency Analyze contrast should so too.

Note that Time Record which also used to have an alpha text "Help" button on Windows has already had that replaced with the iconic "?" button

Comment 1 James Crook 2017-06-06 15:22:17 UTC

*** STEPS UPDATED ***

Note for programmers: These two analyze functions are 'specials' that are not using the standard modules method, and so they do not get the new help button automatically.  They aren't handled by the Plug-in manager either.  One way to fix this bug would be to change them over to using the module system used for example by find clipping.

Comment 2 Steve Daulton 2017-08-10 14:16:57 UTC

My "vote" would be to remove "Contrast" from the default bundle and offer it as an optional module. The main use for Contrast seems to be among audiobook producers for measuring their RMS levels, so I think it would be better to ship a more general tool for measuring RMS.

Comment 3 James Crook 2017-08-14 18:24:20 UTC

DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/db97feafd77840b1dc75b536e6e13c1b077de0f4

Comment 4 Peter Sampson 2017-08-15 05:58:08 UTC

(In reply to James Crook from comment #3)
Testing on macOS Sierra 10.12.6 db97fea 15Aug17

Both the Analyze Contrast and Plot Spectrum now have the new iconic Help buttons, replacing the old textual ones.

Thanks for fixing that James - nice for consistency for 2.2.0

Comment 5 James Crook 2017-08-15 06:29:16 UTC

RESOLVED FIXED
Per comment 4.