Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 1656 - (Windows) Disabled Edit Toolbar buttons not skipped for navigation
(Windows) Disabled Edit Toolbar buttons not skipped for navigation
Status: RESOLVED QUICKFIXED
Product: Audacity
Classification: Unclassified
Component: User Interface
2.2.0
Per OS Windows (all)
: P2 Repeatable
Assigned To: Default Assignee for New Bugs
: test_single_OS
Depends on:
Blocks: 33
  Show dependency treegraph
 
Reported: 2017-06-09 12:34 UTC by Gale Andrews
Modified: 2018-08-20 11:45 UTC (History)
7 users (show)

See Also:
Steps To Reproduce:
B1. Use NVDA to navigate the tooldock. B2. Notice that 'disabled buttons' are not skipped, but instead are announced, slowing navigation. B is different behaviour to 2.1.3, but might not be considered a bug. To be determined.
Release Note:
// See bug 33
First Git SHA:
Group: ---
Workaround:
Closed: 2018-08-20 00:00:00
gale: Accessibility+
gale: Regression+
james.k.crook: Test‑OK‑Win+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gale Andrews 2017-06-09 12:34:47 UTC

    
Comment 1 James Crook 2017-07-04 17:39:38 UTC
*** STEPS UPDATED ***
With this fix, part of the original issue has been fixed.
https://github.com/audacity/audacity/commit/c12f849f36ee5184cc153801787ff31e73a2424b

These steps were removed:

A1. Bring focus to a disabled button such as cut, with cursor in an audio track (auto-select off). This disabling is not reported to Windows, so as to allow tooltips to display even for a disabled button (bug 1565).  
A2. Press ENTER.
A3. Disabled button is acted on as if auto-select was on, removing all the tracks' audio.

The title was changed from:
"(Windows) Disabled Edit Toolbar buttons not skipped for navigation and respond to ENTER as if auto-select was on"

to:
"(Windows) Disabled Edit Toolbar buttons not skipped for navigation"
Comment 2 Paul L 2017-07-21 00:16:22 UTC
I just tried this.  I am not very familiar with NVDA.  I do observe that there are two ways to navigate toolbar buttons.  One is to use the left and right arrow keys, which moves the stippled rectangle.  The other is to use numpad insert + 4 or 6 which is special to NVDA.

I find that I visit the disabled buttons the first way, but not the second way.

Which, exactly, is the complaint in this bug?

To fix the first kind of navigation, those using arrow keys, would have implications for Audacity even without NVDA.  But these consequences might be desirable anyway.
Comment 3 Paul L 2017-07-21 00:43:26 UTC
Now I observe that left and right (and Tab and Shift+Tab) do the right thing on Mac.  Why not on windows?

A peek at AButton.cpp clearly shows that this commit

6478895a3903

with MSW specific effect is at fault.

"Bug 1565 - Windows: Toolbars don't show tooltips when button is disabled"

I suppose it's up to James to reconcile these two conflicting bugs then.
Comment 4 Paul L 2017-07-21 01:02:49 UTC
No wait -- I did it, it was a one-liner!

https://github.com/audacity/audacity/commit/d1f7e7e46fe1cbf9d8094a3d0c3c7a831fdb45f9
Comment 5 James Crook 2017-07-21 10:25:28 UTC
Tested on Windows, with Record-Paused, and no selection.  Tab and shift-tab skip over play button, but not other transport buttons, and skip silence and trim buttons.  Tooltips still show on hover.

RESOLVED QUICKFIXED