Bug 1668 – Loss of "click to place gain/pan slider" ability in Track Control Panel. Gain/Pan adjustment boxes opened with mouse have no affect.

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1668 - Loss of "click to place gain/pan slider" ability in Track Control Panel. Gain/Pan adjustment boxes opened with mouse have no affect.


Summary:	Loss of "click to place gain/pan slider" ability in Track Control Panel. Gain...

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.2.0
Hardware:	Per OS All

Importance:	P1 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:	test_single_OS

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-06-23 22:58 UTC by Gale Andrews
Modified:	2018-08-20 11:51 UTC (History)
CC List:	7 users (show)

See Also:
Steps To Reproduce:	1 Create some mono or stereo audio. Drag the Pan or Gain slider on Track Control Panel with the mouse. The slider responds as expected. 2 Single left-click either side of the slider knob to move the slider to the click position, as you would with Mixer Board and other sliders. There is no slider movement. 3 Double-click anywhere in the either slider to open the adjustment dialogue. Drag the slider or click either side of the knob, or use arrow keys to set the value e.g. Pan hard left and click OK. This does not change the position of the slider in the Track Control Panel, which according to the playback meters plays exactly per the visible position. 4 Keyboard shortcuts to adjust gain and pan and open their adjustment boxes do work correctly. So the main issue is loss of click to move slider for mouse users but I think it a considerable loss. 4 Sliders and their adjustment boxes in the upper tooldock do not seem to be affected.
Release Note:	Regressions on 2.1.3.
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	gale: Regression+ petersampsonaudacity: Test‑OK‑Win? petersampsonaudacity: Test‑OK‑Mac+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2017-06-23 22:58:07 UTC

Borderline P1/P2. I would rather fix it than not so I will go for P1.

Comment 1 Paul L 2017-07-14 10:06:07 UTC

Mostly fixed at f8d9c4217c8c2a3d674d54205826410078f7fb7f

but some other needed safeties only more lately done at

https://github.com/audacity/audacity/commit/e9cb5056f16971580f5ef76a444c61ba36d5345d

Comment 2 Peter Sampson 2017-07-15 05:52:45 UTC

Testing on W10-CE audacity-win-r903ceba-2.2.0-alpha-15-jul-17

Proper functionality of clicking on the Pan and Gain sliders to adjust their setting to that position works aok again now on Windows.

Also works ok for the sliders in the Pan/Gain dropdown menus that you get by double-clicking on the TCP sliders.


One oddity on the dropdown menu pan/gain dialog:  if you clear the daya entry box (used for accurate settings) and press OK, the sliders move to their maximum setting.  I would have expected them to be ventered to zero with null data in the input box.

Comment 3 Peter Sampson 2017-07-15 05:57:45 UTC

(In reply to Peter Sampson from comment #2)
Testing on W10-CE audacity-win-r903ceba-2.2.0-alpha-15-jul-17

Clicking on the Pan/Gain sliders in the Mixer Board also works ok 

But as with the TCP dropdowns entering null data in tha data entry box yields
maximem settings on the sliders rather than the expected (by me anyway) centered zero settings.

Comment 4 Peter Sampson 2017-07-23 12:13:43 UTC

(In reply to Paul L from comment #1)
Testing on macOS Sierra 10.12.5 with Cliff's 22Jul17 build

Proper functionality of clicking on the Pan and Gain sliders to adjust their setting to that position works ok again now on Mac.

Also works ok for the sliders in the Pan/Gain dropdown menus that you get by double-clicking on the TCP sliders.

Comment 5 Bill Wharrie 2017-07-28 18:42:55 UTC

Confirm OK on Mac 10.11.4 commit id 00f6ee.

Comment 6 James Crook 2017-07-31 11:42:00 UTC

RESOLVED QUICKFIXED
Steps to reproduce all work fine.  I note that the gain slider has 'gearing' (x2 ratio) which I hadn't expected, but is fine.  Numerical entry in detail box followed by return closes the box rather than moving the slider in the box.  That's OK.