Bug 1672 – OS window close button crashes Audacity if Screenshot Tools are open. File > Close hides Screenshot tools and then any closure method crashes Audacity.

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1672 - OS window close button crashes Audacity if Screenshot Tools are open. File > Close hides Screenshot tools and then any closure method crashes Audacity.


Summary:	OS window close button crashes Audacity if Screenshot Tools are open. File > ...

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.2.0
Hardware:	Per OS Windows and Linux

Importance:	P2 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:	test_single_OS

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-06-28 15:01 UTC by Gale Andrews
Modified:	2019-11-25 12:55 UTC (History)
CC List:	8 users (show)

See Also:	2250
Steps To Reproduce:	1 Launch Audacity. Don't do anything other than open Screenshot Tools. 2 Capture some screenshots, or not. Press the application close button in the Title Bar. 3 Audacity crashes rather than closing cleanly. 4 Repeat Step 1 but record or create some audio before opening Screenshot Tools. 5 Repeat Step 2. If you say no to "Save changes?" Audacity crashes. If you save changes then Audacity crashes after the save (the saved project seems OK). 6 Observe the Task Manager in Windows after clicking away all crash dialogues. You may or may not see an Audacity background process still running. If it is there, it will prevent Audacity launching next time. A1 Restart Audacity. Add some audio or not. Open Screenshot Tools and capture an image or not. File > Close. Screenshot Tools is now invisible and cannot be reopened from the Help menu. Use any app closure method and Audacity will crash.
Release Note:	GROUP: Interface * '''Using the operating system's window close button to exit Audacity while the Screenshot Tools dialog is open will cause Audacity to crash.''' If you save any unsaved audio as a Project after using window close, the Project will save correctly before Audacity crashes. If you File > Close with Screenshot Tools open, then Screenshot Tools will become invisible. Any method of closing Audacity will cause a crash but again, saved project data should not be harmed. If Audacity does not relaunch after the crash, open Windows Task Manager and end the background Audacity process that is listed.
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	gale: Regression+ james.k.crook: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2017-06-28 15:01:39 UTC

Regression on 2.1.3. Linux and Windows show the symptoms, Mac not tested.

Comment 1 James Crook 2017-07-03 17:05:25 UTC

DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/51c5c73b3b78a6baa5573d7c91ccdb8921954299
https://github.com/audacity/audacity/commit/a5df25f7628d78d11d36d0de3a85f60446f466a2

All steps, i.e. steps 1-6 and A1 tested on Windows.

Also tested attempts to create multiple screenshot tools windows and closing of screenshot tools window and reopening using the menu.  Checked for memory leaks in debug output too, which would be a sign of potentially hidden problems from not properly accounting for ownership of the window.

Comment 2 Peter Sampson 2017-07-18 10:17:27 UTC

testing on W10 audacity-win-ra9a6f01-2.2.0-alpha-18-jul-17

Tested all steps 1-6 with the various combinations involved - and tested Steps A1

No crashes occurred

Looks to be ok on Windows

Comment 3 Peter Sampson 2017-07-20 06:32:39 UTC

(In reply to James Crook from comment #1)
Testing on macOS Sierra 10.12.5 with Cliff's 19Jul17 build.

Tested all steps 1-6 with the various combinations involved - no crashes occurred

With A1 step on Mac the Screenshot tools Window as well as the Audacity window both go with File Close - and the screenshit tools can be re-invoked after relaunching Audacity.