Bug 1673 – Edit >Labels menu is confusing and misleading

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1673 - Edit >Labels menu is confusing and misleading


Summary:	Edit >Labels menu is confusing and misleading

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.2.0
Hardware:	Per OS All

Importance:	P3 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:	test_single_OS

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-07-01 07:52 UTC by Peter Sampson
Modified:	2018-08-20 11:51 UTC (History)
CC List:	7 users (show)

See Also:
Steps To Reproduce:	1) get an audio track and a lebel track with range labels 2) select in just the label track around a couple of the range labels 2) Edit > Labels > Split Cut 3) it is audio that gets deleted - not a split cut in the label track (which is to be expected from the command nomenclature)
Release Note:	To be provided if this bug is not fixed for 2.2.0
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	petersampsonaudacity: Regression? gale: Test‑OK‑Win+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Sampson 2017-07-01 07:52:35 UTC

The 2.2.0 menu rearrangement has created a new (replacement) Menu item Edit >Labels which is a potrtmanteau set of commands that operate on two different classes of objects:  "Labels" and "Labeled Audio" which is confusing and unclear in purpose to the user.

In 2.1.3 we  have a menu item Edit > Labeled Audio which only had commands that operated on labelled (selected) audio.

With 2.2.0 alpha we created the Edit >Labels command which would have been clear if it were only operating on Labels - but instead we confusingly included also all the previous Labeled Audio commands (it certainly confused me yesterday until I had a very careful read of te alpha Manual)

Now I'm all for an Edit > Labels menu - but that should do "what it says on the tin" and operate only on Labels - and the commands in there for: 
Delete/Cut/Split Cut/Split Delete 
should remain - BUT should operate on temporal selected regions of the label track.

Which means that we also need to restore the previous Edit > Labeled Audio command as it was for 2.1.3 and earlier (this is why I flagged this as a potential regression.


We really should be dealing with this as part of the menus changes for 2.2.0.

Comment 1 Steve Daulton 2017-07-01 08:50:46 UTC

Fix made:
https://github.com/audacity/audacity/commit/c457ce3bf3

Comment 2 Gale Andrews 2017-07-01 10:18:25 UTC

Thanks Steve. Can we please have Edit > Labeled Audio instead of Edit > Labled Audio? Your variant would differ from 2.1.3 and would require changes to the Manual.

Comment 3 Peter Sampson 2017-07-01 10:56:28 UTC

Testing on W10 audacity-win-rc457ce3-2.2.0-alpha-01-jul-17-1

Looking good thus far apart from Gale's comment #1


Do we want to consider adding label deletion command(s) to the Edit>Labels menu - or are we happy with it just as it is?

Comment 4 Steve Daulton 2017-07-01 13:27:27 UTC

(In reply to Gale Andrews from comment #2)
Done.
https://github.com/audacity/audacity/commit/bda2e5449

Comment 5 Gale Andrews 2017-07-01 18:53:21 UTC

Thanks, Steve.