Bug 1677 – Swap two tracks and escape leads to crash on exit.

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1677 - Swap two tracks and escape leads to crash on exit.


Summary:	Swap two tracks and escape leads to crash on exit.

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.2.0
Hardware:	Per OS Windows 10

Importance:	P2 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:	test_single_OS

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-07-04 05:36 UTC by James Crook
Modified:	2018-08-20 11:45 UTC (History)
CC List:	7 users (show)

See Also:
Steps To Reproduce:	1. Create a track of 30s using DTMF. 2. Create a second track using Chirp. 3. Swap the tracks using the mouse. 4. Press ESC before releasing the mouse to cancel the swap. 5. Close Audacity and say no to saving. Audacity crashes.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description James Crook 2017-07-04 05:36:42 UTC

After swapping two tracks and undoing, and then exiting, Audacity crashes.

The crash is in code attempting to clean up temporary files, when the code tries to put up a message about that.  It looks as if wxTheApp has already been torn down, and so using wxTheApp->GetTopWindow() as a parent for the progress dialog is not possible, hence the crash.

Comment 1 James Crook 2017-07-04 06:24:45 UTC

*** STEPS UPDATED ***

Undo isn't required.

Comment 2 James Crook 2017-07-04 07:16:51 UTC

DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/9ab40113b78b48160f037057bb024cef665965be

Comment 3 James Crook 2017-07-04 14:47:37 UTC

*** STEPS UPDATED ***
TrackSelectHandle::Release() may not be called if ESC is pressed before releasing the mouse, leading back to the original crash.  Steps updated (and priority reduced to P2) to reflect this.

Comment 4 James Crook 2017-07-04 16:29:33 UTC

DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/d903845a6b4fc30ff135f3d8bb28bdeb472eedbe

Comment 5 Peter Sampson 2017-07-18 10:35:46 UTC

(In reply to James Crook from comment #4)
Tested on W10-CE audacity-win-ra9a6f01-2.2.0-alpha-18-jul-17

Tested the Steps to reproce - no crash after step 5

Repeated the test with several tracks moving them up and down aborting with ESC- no crashes.

Looks to be fixed on Windows

Comment 6 Peter Sampson 2017-07-20 06:38:35 UTC

(In reply to James Crook from comment #4)
Tested on macOS Sierra 10.12.5 Cliff's build 19-jul-17

Tested the Steps to reproduce - no crash after step 5

Repeated the test with several tracks moving them up and down aborting with ESC- no crashes.

Looks to be fixed on Mac