Bug 1683 – Version 4 Nyquist effects crash when applied to stereo tracks

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1683 - Version 4 Nyquist effects crash when applied to stereo tracks


Summary:	Version 4 Nyquist effects crash when applied to stereo tracks

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	Nyquist
Version:	2.2.0
Hardware:	Per OS All

Importance:	P1 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-07-13 05:50 UTC by Gale Andrews
Modified:	2018-08-20 11:45 UTC (History)
CC List:	8 users (show)

See Also:
Steps To Reproduce:	1. Generate or record into a stereo track 2) Run this command at the Nyquist Prompt: (print (get 'track 'end-time)) The prompt should return the end time of the selected track, (in the case of a stereo track, the maximum end time of the two channels). Currently Audacity crashes instead.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	gale: Regression+ petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ stevethefiddle: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gale Andrews 2017-07-13 05:50:26 UTC

Confirmed on Vista and Win 10. Not tested elsewhere.

Comment 1 Steve Daulton 2017-07-13 08:04:24 UTC

Confirmed on Linux.
Set "Hardware: All".

Comment 2 Steve Daulton 2017-07-13 08:59:40 UTC

Also the "Change Speed" effect defaults to nonsense values, which I believe may be related.

Comment 3 Steve Daulton 2017-07-13 09:16:34 UTC

(In reply to Steve Daulton from comment #2)
On further investigation, I think that's an unrelated bug.

Comment 4 Steve Daulton 2017-07-13 16:05:45 UTC

The bug is more general than the original title and occurs with any version 4 Nyquist plug-in when applied to a stereo track.

The crash problem appeared at:
https://github.com/audacity/audacity/commit/16645f6b

and is caused when Nyquist.cpp calls GetStartTime() or GetEndTime() for the first channel of a stereo track (which was previously legal, but appears to not be so now due to changes elsewhere).

Updated bug title and steps to reproduce.

Comment 5 Paul L 2017-07-14 09:23:04 UTC

https://github.com/audacity/audacity/commit/9ad15dabe13b458143ba2a0097b6617314fe9cbd

Comment 6 Steve Daulton 2017-07-14 10:02:29 UTC

(In reply to Paul L from comment #5)
Thanks Paul, works on Linux.

Comment 7 Peter Sampson 2017-07-15 05:36:56 UTC

Tests ok on W10-CE  audacity-win-r903ceba-2.2.0-alpha-15-jul-17

I can no longer test on Mac as nightlies are no longer available right now

Comment 8 Peter Sampson 2017-07-20 06:20:41 UTC

(In reply to Paul L from comment #5)
Tests ok on macOS Sierra 10.12.5 with Cliff's 19Jul17 build