Bugzilla – Bug 1688
MIDI Note tracks can be stretched beyond the Note track boundary - making notes inaccessible
Last modified: 2018-08-20 11:51:46 UTC
Created attachment 729 [details] Overstretched Note track As per the steps to reproduce MIDI Note tracks can be stretched beyond the Note track boundary - making notes inaccessible, uneditable and unplayable. You can however select there in the overstretched "notes" region - you just can't do anything with that selection. The only escape is to use Undo to revert the stretch See also Bug #1646
In contrast if yoe enable scrolling left of zero, you do not apppear to be able stretch the "notes" into blank negative time space at the left of the note track - not even if you have time shifted part of the Note track into negative time.
On Linux, when commencing the drag in step 7, the Note track collapse to about 1/3rd of its original duration. The crucial step in "steps to reproduce" appears to be making a selection that exceeds the length of the Note track.
Fixed at https://github.com/audacity/audacity/commit/e86fd3c9907a7945b6dde78ca16c69a36cb99c26 I found more than one problem here in fact: please try out not just the center stretch cursor but also the start an end cursors, for a time selection going past the end of track.
It still doesn't look right here. 1) Import MIDI file into new project 2) Zoom to fit (bug 1687) 3) Click near the vertical middle about 3/4 of the way along the track and drag slightly to the right. The notes collapse into the left hand 1/3 of the track. Also, if an audio track exists that is longer than the Note track and "all" is selected, clicking on the Note track shrinks the selection to the length of the Note track.
(In reply to Steve Daulton from comment #4) I do not observe #3. Your steps to reproduce don't tell me what length of time is selected before stretching. Did this happen with the left, right, or center stretch cursor? What priority level ought this bug retain now?
(In reply to Paul L from comment #5) Sorry, missed a step: 1a) Select All
(In reply to Paul L from comment #5) > What priority level ought this bug retain now? On Linux the MIDI functionality appears totally broken, so it's like holding up a fragment of eggshell and asking "how broken is this piece?" How important would you say that note stretching is? Note stretching is unstable and unusable here.
(In reply to Steve Daulton from comment #6) I have built at 17c964e39262346e3eda65f061e910b407968fe6 which is after the fix at e86fd3c9907a7945b6dde78ca16c69a36cb99c26 I do as you say, and I do not see the collapse of the notes.
(In reply to Paul L from comment #8) It does not happen every time, just most times. Here's a video of commit 64ce79fef to demonstrate: https://www.youtube.com/watch?v=ZfNOoVbHa-M&feature=youtu.be
Created attachment 730 [details] ra9a6f01 moonphase fault
Testing on W10-CE audacity-win-ra9a6f01-2.2.0-alpha-18-jul-17 The fix for the full-box cursor now has gone moonphase - sometimes workks and sometimes doesn't. At step 7 in the Steps to reproduce (clicking at the cross-hais cursor) the selection shrinks to just the length of the MIDI Note track removing the empty space selection. Dragging the cross-hairs cursor to the right up to the selection boundary sometimes will comprees the "notes" up to the selection boundaty correctly. But sometimes it will collapse the Note track back from the right selection edge and leave some "notes" standed and unusable out in now empty space that occupies where the Note track used to extend to - see Image ra9a6f01.
Testing on W10-CE audacity-win-ra9a6f01-2.2.0-alpha-18-jul-17 1) The right half-box stretches to the right correctly, extending te selection - and compresses to the left within the selection correctly. 2) The left half-box cursor compresses to the right within the selection correctly. When moving it to the left it extends the selection, but can extend the selction and the Note track into negative time before zero.
More fixes at https://github.com/audacity/audacity/commit/bb4a1b862a88a7e76a680dfd507b1d32cd7ee6a1 I think the condition for seeing the "moonphase" may depend on the MIDI file and your screen resolution. If the file is longer and zoomed to fit I think the bug is more likely. The bug may also depend on how fast you drag the mouse. I had an example where I could make the problem reliably on Mac and I fixed it. It was over 6 minutes with many notes and channels (third movemment of Beethoven's 7th).
Testing on W10 audacity-win-ra45f3bb-2.2.0-alpha-22-jul-17 and on macOS Sierra 10.12.5 Cliff's 21Jul17 build Now looking good on both platforms. When you have a selection that extends beyond the Note track into empt space, invoking the full square cross-hairs cursor trims the selection to the extent of the Note track (after or before) so now you don't get the inaccessible notes strung out in empty space. The left and right cross-hairs cursors work fine too.
RESOLVED QUICKFIXED I tried various selections and combinations of left/right/center stretching. The stretched notes stayed within their expected bounds.
