Bug 1697 – Modifying selection with Snap-To is wrong

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1697 - Modifying selection with Snap-To is wrong


Summary:	Modifying selection with Snap-To is wrong

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	Audio IO
Version:	2.2.0
Hardware:	Per OS All

Importance:	P1 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:	test_single_OS

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-07-20 11:24 UTC by Paul L
Modified:	2018-08-20 11:45 UTC (History)
CC List:	8 users (show)

See Also:
Steps To Reproduce:	Generate some audio. Set Snap-to to Nearest or Prior. The unit is unimportant, you can make it seconds. Make a time selection. Then try to modify selection, variously by dragging left or right edges, or by Shift + click and drag, inside or outside the selection. See that sometimes a new selection begins at the mouse-down point, instead of fixing one edge as it was and dragging another.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ stevethefiddle: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Paul L 2017-07-20 11:24:54 UTC

I anticipate a fix for this, which I broke, very soon.  I make a formal bug report so that QA is sure to exercise the fix.

Comment 1 Peter Sampson 2017-07-20 11:33:41 UTC

I elevated this to P1 - we *cannot* release like this, destroying people's carefully made selections.

I confirm that it happens on both W10 and macOS Sierra 10.12.5

Comment 2 Paul L 2017-07-20 11:52:38 UTC

Peter please equip your Mac to play MIDI.

Download SimpleSynth and run it in background:  http://notahat.com/simplesynth/

And follow instructions such as here http://donyaquick.com/working-with-midi-on-mac-os-x/ to set up an IAC driver and make SimpleSynth listen to it.

MIDI play then actually works by an inter-process communication between Audacity and SimpleSynth.  The latter really generates the sound samples.  Audacity only emits Midi events like note turn-ons and offs.

Comment 3 Peter Sampson 2017-07-20 12:13:49 UTC

(In reply to Paul L from comment #2)
Excuse me - but what does this comment have to do with this bug precisely ?

Comment 4 Peter Sampson 2017-07-20 12:45:35 UTC

And please explain, Paul, why you reverted my QA elevation of this bug from P1 back to P2.

Comment 5 Paul L 2017-07-20 13:02:34 UTC

(In reply to Peter Sampson from comment #4)

Sorry, I thought I was elevating it from P4 to P2.  Perhaps our updates crossed.

P1 it is.

Comment 6 Paul L 2017-07-20 13:04:13 UTC

Oh heck, that comment was pertinent to 1691, not this one.

I am having a bad morning.

Comment 7 Paul L 2017-07-20 22:24:02 UTC

Fixed at

https://github.com/audacity/audacity/commit/59dab5222b7923e90151be65887dd581f9552ddb

Comment 8 Peter Sampson 2017-07-22 12:26:38 UTC

(In reply to Paul L from comment #7)
Testing on W10 audacity-win-ra45f3bb-2.2.0-alpha-22-jul-17
and on macOS Sierra 10.12.5 Cliff's 21Jul17 build

Now looking good on both platforms.

Tested shrinking and expanding scconds-snapping existing selections.  All worked as expected.

Comment 9 James Crook 2017-07-31 11:22:20 UTC

RESOLVED QUICKFIXED
Works fine for me with both prior and nearest.  Also checked that ESC works and restores selection to before the drag.  Also reviewed code changes at comment #7.