Bug 1698 – Defaults button of Keyboard preferences violates assertion in Mac debug build

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1698 - Defaults button of Keyboard preferences violates assertion in Mac debug build


Summary:	Defaults button of Keyboard preferences violates assertion in Mac debug build

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	Application Core
Version:	2.2.0
Hardware:	Per OS Other

Importance:	P1 Repeatable
Assigned To:	James Crook

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-07-21 11:09 UTC by Paul L
Modified:	2018-08-20 11:51 UTC (History)
CC List:	8 users (show)

See Also:
Steps To Reproduce:	Command+, Keyboard Press Defaults button Assertion message is wxASSERT_MSG( id != 0 \|\| pSubMenu != NULL , wxT("A MenuItem ID of Zero does not work under Mac") ) ;
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Mac+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Paul L 2017-07-21 11:09:18 UTC

No ill effects seem to happen after dismissing the assertion dialog.  Still, wxWidgets is complaining about something improper, so give it a look.

Comment 1 Peter Sampson 2017-07-27 10:59:45 UTC

Even without a fix 

Testing on macOS Sierra10.12.5 00g8658 27Jul17 nightly build

I get no assertion dialog with the Defaults button in Keyboard prefs on Mac - rather I just get the ability sto select Full or Standard default sets,

So AFAICT this seems to be working on Mac

Comment 2 Cliff Scott 2017-07-27 11:55:05 UTC

Works ok on this Mac 10.12.5 as well.

Comment 3 Paul L 2017-08-01 10:05:18 UTC

Fixed at https://github.com/audacity/audacity/commit/5bdac8b4d715a6516997a7ad1db4fa18b17baeef

Comment 4 Peter Sampson 2017-08-03 04:43:32 UTC

(In reply to Paul L from comment #3)
Testing on macOS Sierra 10.12.6 3e39771 03Aug17 debug and non-debug versions

Neither gave an assert or a crash when using the debug or non-debug versions.

In both I was able to use the Defaults button to set both the Standard and Full sets of keyboard Preferences.

I also tested all the other buttons in that dialog on both debug and non-debug.

Just to be sure I also tested an older debug version - and there I did get the asseert/crash.

Looks to be fixed so I will mark this bug as Resolved Quickfixed