Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 1721 - EQ effect in Graphic mode does not display the chosen preset curve name
EQ effect in Graphic mode does not display the chosen preset curve name
Status: RESOLVED FIXED
Product: Audacity
Classification: Unclassified
Component: Built-in FX
2.2.0
Per OS All
: P4 Enhancement
Assigned To: Default Assignee for New Bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-17 10:57 UTC by Peter Sampson
Modified: 2019-05-15 04:39 UTC (History)
6 users (show)

See Also:
Steps To Reproduce:
1) get and select some Audio 2) Effect > Equalization 3) Check radio button for "Graphic" mode 4) Select curve: RIAA 5) Observe that the correct curve appears - but the curve name remains as "unnamed" 6) Check radio button for "Draw" mode 7) Eq switches to that mode - curve is correct, but the curve name still remains as "unnamed" 8) Select curve: RIAA 9) observe that the curve remains the same - but now the curve name changes to "RIAA" 10) Check radio button for "Graphic" mode 11) Observe that the correct curve remains - but the curve name changes to "unnamed"
Release Note:
Group: Effects When using the Equalization effect in Graphic mode you can correctly select named preset curves. This will display correctly - but the curve name will remain as "unnamed". This does not happen if you use Equalization in Draw mode - but if you switch from Graphic to Draw with the "unnamed" correct curve you will still see it showing as "unnamed" in Draw mode. You can correct this simply by re-selecting it.
First Git SHA:
Group: ---
Workaround:
Closed: 2019-05-15 00:00:00
billwh: Vote‑To‑Keep-
james.k.crook: Vote‑To‑Keep-
petersampsonaudacity: Test‑OK‑Win+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Sampson 2017-08-17 10:57:31 UTC
Equalization effect in Graphic mode enables you to selct preset named curves which are displayed correctly but it does not display the chosen preset curve name, instead "unnamed" remains as the curve name.

Tested on latest Windows and Mac nightlies - happens on both, so assume All.

I did not mark this a regression as there appears to be different erroneous behavior in 2.1.3 AFAICT.
Comment 1 Peter Sampson 2017-08-17 10:59:25 UTC
(In reply to Peter Sampson from comment #0)
See the steps to reproduce and Release Note for further subleties of this behavior
Comment 2 Bill Wharrie 2017-08-18 14:17:00 UTC
(In reply to Peter Sampson from comment #1)
I remember having a conversation with one of the developers about this very behaviour. As I recall, this is not a bug. The issue is that a drawn curve cannot be exactly represented in graphic mode. In your example of the RIAA curve it appears that the curve drawn in graphic and draw modes are the same. A close examination shows that the curves are not identical.
For a more extreme example, try this
1) get and select some audio
2) Effect > Equalization
3) Draw mode
4) Select "Telephone" curve
(if it doesn't show, select "Telephone" again)
5) Drag slider for the "below 0 dB scale" down so that bottom of left scale is -96dB or so
6) Switch to graphic mode
Observe that the curve is unlike the draw version, so it is appropriate that it is no longer named "Telephone"
7) Switch to draw mode
Observe that the curve maintains the "graphic mode" shape, but the name has remained "untitled", as it should.

So, not-a-bug, but if what I've said is true it should probably be documented in the manual.
Comment 3 Bill Wharrie 2017-08-18 15:39:55 UTC
(In reply to Bill Wharrie from comment #2)
Ah, I see this is already covered in the manual:
https://alphamanual.audacityteam.org/man/Equalization#settings

I've added a green note div to highlight it.
Comment 4 Peter Sampson 2017-08-19 06:55:03 UTC
(In reply to Bill Wharrie from comment #2)
In which case, maybe we should not be allowing users to use the pre-set curves when using graphic mode (and maybe that would include user curves if thay cannot be expressed accurately in Graphic mode - especially user curves that were created
in Draw mode.
Comment 5 Bill Wharrie 2017-08-31 17:23:54 UTC
Changing this to P4 Enh because it is not a bug and the current behaviour is properly documented in the manual. 
If someone else thinks this should be CLOSED - INVALID/WONTFIX I would support that.
Comment 6 Peter Sampson 2019-05-15 04:39:10 UTC
Testing on W10 with 2.3.2 

when using the "Save/Manage Curves" button to change the curve (both pre-defined and user-defined) in both Draw Mode and Graphic mode the selected curve name is properly displayed.


The related issue is that if the user also uses curves saved und the newer "Manage" button then these names do not display - but more importantly the curve does not get deployed.  But this is the essence of Bug #2031 
>P2 2031: Equalization: presets under the Manage button do not save custom EQ curves
and is thus a separate issue - that needs to be dealt with separately

The bug as defined in the title is RESOLVED AFAICT - thus I shall close this bug.