Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 1722 - Equalization effect: possible crash when using Manage > User Presets
Equalization effect: possible crash when using Manage > User Presets
Status: RESOLVED FIXED
Product: Audacity
Classification: Unclassified
Component: Built-in FX
2.2.0
Per OS All
: P2 RepeatableAll
Assigned To: Default Assignee for New Bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-18 18:33 UTC by Bill Wharrie
Modified: 2019-08-22 05:29 UTC (History)
5 users (show)

See Also:
Steps To Reproduce:
1) load some audio and select it 2) Effect > Equalization 3) EQ Type: Draw 4) Select Curve: any named curve 5) Modify the curve 6) Save/Manage Curves 7) Rename the unnamed curve and OK 8) Manage > Save Preset 9) Save a user preset and OK 10) Save/Manage Curves > Defaults This removes the named curve you saved in (7) 11) Manage > User Presets > [the preset you saved in (9)] Hang. Force quit required
Release Note:
GROUP: Effects * '''Equalization''': do not use the "Manage > Save Preset" function to save a custom curve; use "Save / Manage Curves" instead. Using the "Manage" button to save and recall presets can cause unexpected results, and in rare cases can cause Audacity to hang.
First Git SHA:
Group: ---
Workaround:
Closed: 2019-08-22 00:00:00


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bill Wharrie 2017-08-18 18:33:40 UTC

    
Comment 1 Bill Wharrie 2017-08-18 18:35:26 UTC
Is it possible to grey out "Manage > Save Preset" in the EQ effect? We already say in the manual that the presets feature is not working. Greying out "Save Preset" would prevent bad things from happening.
Comment 2 Peter Sampson 2017-08-19 07:21:04 UTC
(In reply to Bill Wharrie from comment #1)
I fully support this (and more ...).

Apart from the potential crash situation it seemms nonsensical to have the two formas of curve management in EQ
a) EQ's own Save/Manage Curves
b) the Manage button

Note that: 

a) is where the preset=curves are stored an managed from (i.e. the pukka way for EQ) is via this mech.

b) with this the Manage>Factory Presets soes not work
b1) it does not restore the default flat curve
b2) if you use it in Graphic mode it switches you into Draw mode - it should not

So maybe we should be:
1) graying out all the "Manage> *** Preset(s)" commands, or
2) graying out the Manage button in EQ
3) removing the Manage button in EQ

Or more radically
5) retain the "Manage> *** Preset(s)" commands - but make thes go to the Save/Manage curves dialog.
Comment 3 Peter Sampson 2019-05-11 09:55:50 UTC
Testing on W10 with RC001 for 2.3.2

I cannot reproduce this

A) indeed at Step 10 my new names curve has disappeared

B) but at Step 11 "User Presets" is grayed out  and no crash can occur or occurs 

or if I already have a user preset then it is not grayed out bit the preset I "saved" at step 9 is not shown in the available user presets list - so once again no crash.

But I think this bug stays open pending the planned separation of EQ into two separate effects for the two modes - and the simplification, unification and standardization of managing presets.

So this remains thereby a target bug for fixing in 2.3.3
Comment 4 Steve Daulton 2019-05-19 19:21:04 UTC
See also bug 2112.
Comment 5 Peter Sampson 2019-08-21 12:02:02 UTC
Elevating to P2 to raise focus-level for the EQ split & maintenance planned for 2.3.3 - and P2 because of crash
Comment 6 Peter Sampson 2019-08-22 05:29:45 UTC
Testing on W10 with audacity-2.3.3-alpha-326-c9fbd283b7bfc8702caf86a4672cba7ff6260b7d

This now works with the user preset not being lost (same occurs independently in the two new split EQ effects.

This loks to be fixed as a side effect of fixing Bug #2031