Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



Bug 1730 - Help on Internet dialog non-responsive when invoked by help button on "No Audio Selected" dialog
Help on Internet dialog non-responsive when invoked by help button on "No Aud...
Status: RESOLVED QUICKFIXED
Product: Audacity
Classification: Unclassified
Component: User Interface
2.2.0
Per OS macOS and Linux
: P3 Repeatable
Assigned To: Default Assignee for New Bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-31 19:06 UTC by Bill Wharrie
Modified: 2018-08-20 11:51 UTC (History)
5 users (show)

See Also:
Steps To Reproduce:
Make sure the local manual is not installed. This is standard on Linux. On Mac, open the bundle and remove the "help folder". 1) Import or create a track 2) Make sure there is no selection 3) Effect > Amplify 4) The "No Audio Selected" dialog appears 5) Click the (?) button 6) The "Help on the internet" dialog opens 7) Nothing in the "Help on the internet" dialog is responsive: the "Close" button does not work, the links do not work and the dialog cannot be closed with the window's close button 8) To close the "Help on the internet" dialog you must click the "OK" button in the "No Audio Selected" dialog.
Release Note:
GROUP: Interface * If the local manual is not installed (standard on Linux, optional according to your download choice on Mac and Windows), clicking the (?) help button in the "No Audio Selected" dialog will bring up the "Help on the internet" dialog, but thoat dialog may not not responsive. You must click the "OK" button in the dialog to proceed. '''Solution''': go to Preferences > Interface and change "Location of Manual" to "From Internet".
First Git SHA:
Group: ---
Workaround:
Closed: 2018-08-20 00:00:00
petersampsonaudacity: Test‑OK‑Win+
petersampsonaudacity: Test‑OK‑Mac+
petersampsonaudacity: Test‑OK‑Lin+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bill Wharrie 2017-08-31 19:06:22 UTC
Confirmed by Steve (Linux) and Bill (Mac). Rating P3 as there is an easy workaround/solution.
Comment 1 Peter Sampson 2017-09-01 06:11:25 UTC
(In reply to Bill Wharrie from comment #0)
Testing with the Mac Beta Beta build 01Sep17 on macOS Sierrra 10.12.6
a) I confirm the same reproprted error behavior
b) I confirm that Bill's workaround in the release note does work
Comment 2 Peter Sampson 2017-09-04 06:23:11 UTC
And just as a sanity check - this works fine on Windows with the 02Sep17 Beta
Comment 3 Steve Daulton 2017-09-04 07:17:38 UTC
(In reply to Peter Sampson from comment #2)
Do you mean that the workaround works in the beta version?

On Linux, the bug was present in e238845d
Should be fixed in
https://github.com/audacity/audacity/commit/b9aaec6

Please test on all platforms, and also test other actions that should 'not be allowed'.
Comment 4 Peter Sampson 2017-09-04 07:23:21 UTC
(In reply to Steve Daulton from comment #3)
>Do you mean that the workaround works in the beta version?

Yes it the workaround works with the Beta on Mac
Comment 5 Peter Sampson 2017-09-05 03:58:49 UTC
Testing on macOS Sierra 10.12.6 
(alpha but labelled as Beta) d7cc85b 05Sep17

This now works fine on the latest alpha (obviously not incorporated into the Beta yet - as Beta dates from 02Sep17 before Steve's fix for this).

With no local Manual available the "Help on the Internet" now is actionable and all its buttons operate correctly (to the online MAnula and to download the Manual).


It works correctly already on W10 with the 02Sep17 Beta - but should really be checked on the next Beta or RC to be sure that this still works on Windows with Steve's latest changes.
Comment 6 Peter Sampson 2017-09-05 04:20:12 UTC
Testing Bug #1733 revealed that I have exactly the same inoperable "Help on the Internet" dialog with the "Error opening sound device..." with no local manual available.


Since we now have seen this with two error messages (one fixed) this implies that it may well be a problem with other error messages, some of which are not easy to provoke and thus this research may be most easily conducted by examining, and correcting the code if necessary.
Comment 7 Steve Daulton 2017-09-05 09:04:01 UTC
(In reply to Steve Daulton from comment #3)
Steve wrote:
> also test other actions that should 'not be allowed'.

By that, I meant specifically the error messages from the Command Manager when a command has been prohibited. It's quite a short list and most of these messages should never appear.

This is the full list ofl messages that are relevant to bug 1730.
They come under the title "Tell User Why Disallowed" and in each case the help page is:
helpPage = "Selecting_Audio_-_the_basics"

Lines beginning with // are code comments that give some explanation of context. The "reason" is the message content that is displayed when an action has been disallowed.

-----

// The default string for 'reason' is a catch all.  I hope it won't ever be seen
// and that we will get something more specific.
reason = "There was a problem with your last action. If you think\nthis is a bug, please tell us exactly where it occurred."


// This reason will not be shown, because options that require it will be greyed our.
reason = "You can only do this when playing and recording are\nstopped. (Pausing is not sufficient.)."


// This reason will not be shown, because the stereo-to-mono is greyed out if not allowed.
reason = "You must first select some stereo audio to perform this\naction. (You cannot use this with mono.)"


// %s will be replaced by the name of an action, such as Normalize, Cut, Fade.
reason = "Select the audio for %s to use (for example, Ctrl + A to Select All) then try again."


// Mac version
// %s will be replaced by the name of an action, such as Normalize, Cut, Fade.
reason = "Select the audio for %s to use (for example, Cmd + A to Select All) then try again."


reason = "You must first select some audio to perform this action.\n(Selecting other kinds of track won't work.)"

-----
Comment 8 Peter Sampson 2017-09-05 09:56:20 UTC
Comment #6 has been spun off into its own separate Bug #1740

So the original error reported in this bug thread works properly on the latest 05Sep17 alpha build - therefore marked os OK on Mac.

Steve confirmed by email that this tests ok on Linux - so flagged as such.

We should not close this bug as resolved until we test that it works on Windows too - currently we have no Windows nighlies so this may have to wait until the next Beta or RC.
Comment 9 Peter Sampson 2017-09-07 11:47:55 UTC
Tested om W10 audacity-win-7314de6-2.2.0-beta-7Sep17

Works correctly on W10.

With no local Manual installed clicking on the "?" help icon in this error message yields the "Help on the Internet" message - and both links in that message worl properly

Wiith a local Manual installed clicking on the "?" help icon in this error message goes direc to the appropraie page in the local MAnual.

Looks to be fixed on all 3 platforms - so I will mark as RESOLVED