Bug 1742 – Built-in Macro name "MP3 Conversion" does not translate

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1742 - Built-in Macro name "MP3 Conversion" does not translate


Summary:	Built-in Macro name "MP3 Conversion" does not translate

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Scripts
Version:	2.2.0
Hardware:	Per OS Other

Importance:	P4 Locale
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-09-06 12:49 UTC by Paul L
Modified:	2019-08-14 05:12 UTC (History)
CC List:	2 users (show)

See Also:
Steps To Reproduce:	Open Edit Macro dialog with language other than System or en.
Release Note:
First Git SHA:
Group:	Locale
Workaround:
Closed:	2019-08-13 00:00:00

Attachments
Macros dialog in German (16.95 KB, image/png) 2019-08-14 04:37 UTC, Peter Sampson	Details
Macros dialog in French (15.58 KB, image/png) 2019-08-14 04:38 UTC, Peter Sampson	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Paul L 2017-09-06 12:49:16 UTC

Comment 1 Paul L 2017-09-06 13:24:47 UTC

This should not be fixed hastily.  I think the user-visible string is also being used as a key in internal hashes.  Other bugs could happen if you use the translated key in hash lookup.

Comment 2 Paul L 2017-09-06 13:25:58 UTC

Or rather, not a hash lookup, but a presumed correspondence of string names with certain file names.

You would not want to change language, for instance, but then lose changes you made to the MP3 Conversion chain because now the file name is different.

Comment 3 Peter Sampson 2019-08-14 04:36:52 UTC

Testing on 2.3.0 and 2.3.3 alpha audacity-2.3.3-alpha-317-44c46f7574e89638823c6cc895caa2cd5135d427 (using the 2.3.2 Language files).

Testing with French and German the built-in "MP3 conversion" can now bee seen translated.


The images in the attachments (to follow) are from 2.3.3 with 2.3.2 language files - so not the new button "Restore" is as yet untranslated.



---------------------------------------------

Testing this has thrown up a more serious issue re Macros in foreign languages which I will log as a new bug.

Comment 4 Peter Sampson 2019-08-14 04:37:48 UTC

Created attachment 852 [details]
Macros dialog in German

Comment 5 Peter Sampson 2019-08-14 04:38:43 UTC

Created attachment 853 [details]
Macros dialog in French

Comment 6 Peter Sampson 2019-08-14 04:39:54 UTC

I also tested the Macros Palette dialog and the translations are OK there too.

Comment 7 Peter Sampson 2019-08-14 05:12:10 UTC

(In reply to Peter Sampson from comment #3)
>Testing this has thrown up a more serious issue re Macros in 
>foreign languages which I will log as a new bug.

Logged as P2 locale Bug #2198