Bug 1744 – Equalization Draw curves not operational with linear frequency scale on first use

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1744 - Equalization Draw curves not operational with linear frequency scale on first use


Summary:	Equalization Draw curves not operational with linear frequency scale on first...

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Built-in FX
Version:	unspecified
Hardware:	Per OS All

Importance:	P4 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-09-06 16:12 UTC by Steve Daulton
Modified:	2018-08-20 11:45 UTC (History)
CC List:	4 users (show)

See Also:
Steps To Reproduce:	Set Equalization to "Draw" and frequency scale to "Linear", then attempt to draw a curve. Nothing appears to happen. Deselect "Linear" and notice that the curve appears to have been drawn with a logarithmic frequency scale.
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+ billwh: Test‑OK‑Mac+ petersampsonaudacity: Test‑OK‑Mac+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2017-09-06 16:12:04 UTC

When the frequency scale in "Equalization" is set to linear, and "Eq type" set to "Draw", it is not possible to draw the curve.

Comment 1 Paul L 2017-09-09 22:28:58 UTC

A regression on 2.1.3, and it bisects to my commit
0af9b46eac4a64181d30f78bd2145236cc495f35
which was very early in 2.2.0 development.

Comment 2 Paul L 2017-09-09 22:52:44 UTC

Fixed at https://github.com/audacity/audacity/commit/cc3c56818a5b816f492bdae756e54afb2be7b1d9

Comment 3 Bill Wharrie 2017-09-14 10:28:42 UTC

This is still not fixed.
I'm testing on Mac 10.11.4, Audacity nightly commit 75d557
1) Delete pluginsettings.cfg
2) Start Audacity
3) Generate tone
4) Effect > Equalization
5) Check "Linear frequency scale"
Note that curve moves up to 1 dB
6) Click anywhere on the curve
Note that a control point appears at 0 Hz
7) Click again anywhere on the curve
You cannot create a second control point, only move the whole straight-line curve up and down
8) Cancel the EQ effect
9) Effect > Equalization
You now have a straight-line curve at 0 dB with no control points, and "Linear frequency scale" is checked.

You can now click to create control points, and drag them around.

Comment 4 Paul L 2017-09-14 19:35:07 UTC

I do not observe these problems on a Mac debug build of commit 75d5574.

Comment 5 Paul L 2017-09-14 19:42:48 UTC

Now I have reproduced the problem.  A precondition is that the EQ*.xml files are not present.  But I had these left over from previous runs in which I saved EQ curves.

Comment 6 Paul L 2017-09-16 12:30:36 UTC

Fixed at https://github.com/audacity/audacity/commit/a5aaaf5176e13ad7ee8a139fce4b5f430e85a768

This bug was not a regression on 2.1.3.

Comment 7 Peter Sampson 2017-09-27 12:14:34 UTC

Testing on W10 audacity-win-4a0fbf8-2.2.0-beta-26Sep17
and on macOS Sierra 10.12.6 4a0fbf8 27Sep17

Tests ok on both platforms can draw in Libera Scale properly, shift to log scale and back to linear scale - all drawn properly.

Cn similarly draw orginally in log scale and shift back and forth between scales.

Tested both the steps to reproduce and Bills steps in comment #3

Looks to be fixed