Bugzilla – Bug 1750
Equalization: EQ control points can disappear if the points are at the same frequency
Last modified: 2019-08-24 12:49:33 UTC
This is a regression on 2.1.3.
This is a regression on 2.1.3 It affects not just the simple use case in the steps to reproduce, but also in any EQ curve you make that has a true vertical component somewhere. Also impacts the stored curves using user presets in "Manage" or in "Save/Manage Curves" which are not stored/retrieved properly. Affects both W10 and macOS 10.13.1 - so assume "All" Steps for simple example: 0)Virgin install ar total confif reset 1) get some audio 2) Effect > Equalization 3) set a "curve" with a horizontal, a true vertical and a horizontal 4) apply then effect with the OK 5) Effect > Equalization 6) observe that the shape from step 3 is not "recalled" by Audacity - all you see is one horizontal line See attachments I promoted this to P3 (marginal P2 I'm thinking) because the user has no way to save the "curve", not with the Audacity "remember" nor with either of the save curves functions - and thus they would need to recreate each time. Plus the fact that this is a relatively recent regression.
Created attachment 745 [details] right-angular curve at Comment #1 Step #3
Created attachment 746 [details] Errant straight line curve at Comment #1 Steps #5-#6
*** Bug 1798 has been marked as a duplicate of this bug. ***
Also affects preview and save curve. To reproduce: 1) Create a 'curve' has two points at the same time position (a "step"). 2) Either: a. Preview b. Save Curve One of the points in the "step" disappears. Reported on Windows, confirmed on Linux.
More weirdness with vertical lines in Draw Curves. Draw a band filter that has two vertical components and one horizontal component. Click Invert. The inverted curve bears little relation to the original. Click Invert. Nothing happens.
I've raised this to P2 in response to feedback on the forum indicating that this bug is affecting real users.
Testing on W10 with audacity-2.3.3-alpha-326-c9fbd283b7bfc8702caf86a4672cba7ff6260b7d This is still the case - and it also similarly affects the new spit EQ effect called "Filter Curve"
Similar occurs with the two new effects 1) In Filter Curve 2) Draw a curve with two points at the same frequency but different levels 3) Switch to Graphic EQ 4) switch back to Filter curve 5) Observe intermediate control point is discarded, lost
Elevating to P1: a) it causes real iusers to lose carefully made settings (which they may not immediately realize) b) it's a regression c) we will have focus on revamped EQ for this release - so it should be good and watertight.
DEVEL - FIX MADE https://github.com/audacity/audacity/commit/83ddabc8955b2836050203d611e0ee3f6ef2745c
(In reply to James Crook from comment #12) Testing on W10 with audacity-2.3.3-alpha-333-569028268d68d8b7df596d40ad95b27e062f16df 1) Testing with EQ Curves and a stack of points at the same frequency, flipping in and out of Linear - all the points are retained. The old Equalization which is currently still there also works like this now. 2) There is no interaction, no curve sharing, between EQ Curves and EQ Graphic so the original steps can no longer apply - similarly my test in Comment #10 can no longer apply. This works now as expected on W10
