Bug 1758 – On macOS High Sierra - after a failed project save (insufficient space) the data folder is not deleted

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1758 - On macOS High Sierra - after a failed project save (insufficient space) the data folder is not deleted


Summary:	On macOS High Sierra - after a failed project save (insufficient space) the d...

Status:	RESOLVED QUICKFIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.2.0
Hardware:	Per OS macOS

Importance:	P3 Repeatable
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-10-19 05:38 UTC by Peter Sampson
Modified:	2018-08-20 11:51 UTC (History)
CC List:	5 users (show)

See Also:
Steps To Reproduce:	1) insert a USB clip drive with limited free space 2) Open an Audacity project on Mac which is bigger than the free space in 1 3) Save the Project to the USB clip drive 4) Save starts but does not complete - generates an error message 5) acknowledge the error message 6) In Finder, examine the contents of the clip drive 7) observe that the data folder for the failed project save still exists (containing sub-folders and .au files) leaving the clip dive full.
Release Note:	Group: Projects * '''(macOS 10.13)''' if you attempt to save a project to a drive with insufficient space for the project, Audacity will abort the Save and give you an error message. But it will not remove the (useless) project data folder from your drive, leaving the drive full. '''Workaround:''' use Finder to remove the project data folder.
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Mac+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Sampson 2017-10-19 05:38:25 UTC

As per the title, Steps t reproduce and Release notes

This happens consistently for me on macOS High Sierra 10.13

Paul L. advises me that it does not happen for him on El Capitan - the data file is removed

It does not happen for me on W10 home - the data file is removed


This is not a regression as the clean-up code was introduced in late 2.2.0 development by Paul L.

Comment 1 Peter Sampson 2017-10-19 05:39:05 UTC

Additional testing on macOS 10.12.x Sierra would be useful.

Comment 2 Cliff Scott 2017-10-19 11:46:26 UTC

Tested on MacOS Sierra 10.12.6 and cleanup is done properly in all cases.

Tried 3 cases with various free space amounts: 800MB, 94MB and 4.7MB. Data files were removed after the disk full condition in all cases.

Comment 3 Peter Sampson 2017-10-20 10:22:28 UTC

Repeated this test with the new build 2.2.0 TC1-3 20Oct17

This still fails with no cleanup - after Audacity advises that the project cannot be saved, the project's data folder remains with subfolders and .au files -and the USB clip drive remains full with zero bytes available - and of course no .aup file.

Comment 4 Peter Sampson 2017-10-20 10:55:03 UTC

Following from Cliff's comments about headroom...

Retested with a four hour project to Save and an empty 256 MB clip drive - and this time it cleaned up the clip drive prop[erly after the failure leaving it nice and empty.

Comment 5 Peter Sampson 2017-10-27 10:31:01 UTC

Retested on RC! 26Oct17 on High Sierra macOS 10.13

all OK with noth big headroom and limited headroom om the drive