Bug 1762 – Importing keystrokes can fail to import keystrokes that are not in standard set

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1762 - Importing keystrokes can fail to import keystrokes that are not in standard set


Summary:	Importing keystrokes can fail to import keystrokes that are not in standard set

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.3.1
Hardware:	Per OS All

Importance:	P3 Accessibility
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-10-28 14:43 UTC by David Bailes
Modified:	2019-10-19 08:55 UTC (History)
CC List:	5 users (show)

See Also:	624
Steps To Reproduce:	1. Using Audacity 2.3.1, set the default shortcuts to full, and customize a shortcut which is only in full set. Export the keyboard shortcuts to an xml file. 2. Open Audacity 2.3.1 which has no prior config files, or set the keyboard shortcuts to standard. 3. In keyboard preferences, import the saved xml file. The keystrokes for commands that are not in the standard set of default keystrokes but are in the full set are not imported. An exception is if one of these commands has a customized keystroke, it is imported.
Release Note:	GROUP: Interface * '''When importing key bindings''' (keyboard shortcuts) in [https://manual.audacityteam.org/man/keyboard_preferences.html Keyboard Preferences], some may fail to import.
First Git SHA:	58f07d2
Group:	Accessibility
Workaround:	In Keyboard Preferences, set ''Defaults'' to ''Full'' before importing the xml file.
Closed:	2019-04-13 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ stevethefiddle: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description David Bailes 2017-10-28 14:43:29 UTC

Reported by a member of the Audacity4Blind list. See steps to reproduce.

A work around is to first set Audacity 2.2.0 to use the full default keystrokes, and then import the keystrokes file.

Comment 1 David Bailes 2019-04-02 10:20:32 UTC

Changed steps to reproduce.

Fixed in:
https://github.com/audacity/audacity/commit/d994ad430a092d4149ae5e611b0c5e334ccc0502

As noted in the commit text, this fix results in a change of behaviour:

Before: if you'd customized the shortcut for a command, then if you imported a set of shortcuts, that customized shortcut would only have been changed if the imported shortcut was also customized.

Now: If you import a set of shortcuts, then these become your shortcuts, regardless of any customizations present before the import.

I think the new behaviour is what a user would expect.

Comment 2 Peter Sampson 2019-04-08 09:28:26 UTC

(In reply to David Bailes from comment #1)
Tested on W10 with audacity-2.3.2-alpha-219-9ba023d607cb8a79cdf90c9b0ef9dec9af98e6a9

David wrote:

>Now: If you import a set of shortcuts, then these become your shortcuts, >regardless of any customizations present before the import.
>I think the new behaviour is what a user would expect.

I strongly  agree with David and this is now the behavior that I observe with 2.3.2 on W10

Comment 3 Peter Sampson 2019-04-08 09:35:51 UTC

And testing on macOS 10,1,4,4 with James' latest Mac alpha build of 06Apr19

I also observe the revised behavior that David describes in Comment #1

Comment 4 Steve Daulton 2019-04-13 11:49:14 UTC

Works for me. Marked as Fixed.