Bug 1766 – Invalid check for unsupported Nyquist plug-in version

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1766 - Invalid check for unsupported Nyquist plug-in version


Summary:	Invalid check for unsupported Nyquist plug-in version

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	Nyquist
Version:	unspecified
Hardware:	Per OS All

Importance:	P4 Repeatable
Assigned To:	Steve Daulton

URL:
Keywords:	nyquist

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-11-02 10:16 UTC by Steve Daulton
Modified:	2018-08-20 11:51 UTC (History)
CC List:	3 users (show)

See Also:
Steps To Reproduce:	View typo in Nyquist.cpp
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2018-08-20 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Daulton 2017-11-02 10:16:30 UTC

In Nyquist.cpp the check for invalid plug-in version is:
if (v < 1 && v > 4) {

but should be:
if (v < 1 || v > 4) {

Assigned to myself.

Comment 1 James Crook 2017-11-04 14:23:09 UTC

DEVEL FIX MADE

https://github.com/audacity/audacity/commit/7c49019669716e2ceb375c5ce11646f7e9ec1be3

Comment 2 Steve Daulton 2017-11-05 08:32:51 UTC

Not a big issue in this case as it was a trivial fix, but I suggest (in future) that we have some communication before taking over bugs that are assigned to another developer.