Audacity Bug Summary
••• Introduction •••
••• Keywords •••
    Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla



First Last Prev Next    This bug is not in your last search results.
Bug 1786 - Duplicate shortcuts can be created
Duplicate shortcuts can be created
Status: RESOLVED FIXED
Product: Audacity
Classification: Unclassified
Component: User Interface
2.2.1
Per OS Windows (all)
: P3 RepeatableAll
Assigned To: Default Assignee for New Bugs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2017-11-17 08:08 UTC by David Bailes
Modified: 2018-08-20 11:51 UTC (History)
6 users (show)

See Also:
Steps To Reproduce:
1. Upgrade from Audacity 2.1.3 to 2.3.0. To do this I used portable versions of 2.1.3 and 2.3.0, and created portable settings folders for both. I ran 2.1.3 once, then copied the contents of the portable settings folder of 2.1.3 to 2.3.0. 2. In 2.3.0, set the shortcut of the about dialog to the letter A, which should leave the previous tool command with no shortcut. 3. In the main window, press the letter A - the previous tool command is executed. 4. Open preferences and search for the shortcut A. It is assigned both to the About dialog, and the previous tool.
Release Note:
GROUP: Interface * '''After upgrading from version 2.1.3, it is possible to create duplicate key bindings (keyboard shortcuts)''' if you create a keyboard shortcut that is the same as an existing shortcut that exists only in the full set.<br>'''Workarounds:''' **Set the defaults to full set before creating custom keyboard shortcuts (but you will lose any custom shortcuts you had set in 2.1.3). **Set the command which has the shortcut only in the full set to another shortcut. For example if you want to set the shortcut "A" to a command other than "Next Tool", first set the "Next Tool" shortcut to something other than "A". Note that clearing the shortcut does ''not'' work.
First Git SHA: 58f07d2021d239bb23cbf56afee24e2924ba58e1
Group: ---
Workaround:
Closed: 2018-08-20 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Bailes 2017-11-17 08:08:32 UTC 
See steps to reproduce.

Additional notes:
The problem only occurs if you set a shortcut which conflicts with a shortcut which is only in the full set.

Possible work a rounds, neither of which is very attractive.
1. Set the defaults to full set. (You loose all your custom keystrokes).
2. Set the command which has the shortcut only in the full set to another shortcut. Using the example in steps to reproduce, you could set the previous tool shortcut to 9. Note that clearing the shortcut does NOT work.

This bug was reported in the forum:
https://forum.audacityteam.org/viewtopic.php?p=337315&sid=e6d02c800280305a254b58267ed806f9#p337315

They report that they had conflicts by just upgrading. I have not been able to reproduce this, but there may well be a problem in this area, possibly related to this bug.
Comment 1 David Bailes 2018-02-15 07:25:10 UTC 
Here's a fix for this bug:
https://github.com/DavidBailes/audacity/commit/cdde2ba867e5ba74e93d9f972aa135e07c8dde61

I haven't committed it to Audacity main, as we are currently in beta.
Comment 3 James Crook 2018-04-13 10:54:41 UTC 
*** STEPS UPDATED ***
Comment 4 Peter Sampson 2018-04-13 11:59:59 UTC 
(In reply to David Bailes from comment #2)
(In reply to David Bailes from comment #2)
0) cleared out my cfg folder to get virgin OOTB settings
1) I installed 2.1.3 in c:Program Files (x86)\Audacity Bug 1786 (by copying m the contents of my 2.1.3 folder
2)Ran it up to check it was 2.1.3
3) examined keyboard prefs - Previous Tool had A assigned - About Audacity had nothing assigned
4) Installed James latest Appveyor build audacity-2.3.0-alpha-12-71f49ae0f63578abc3a9cfc6f270a0393471d1ac over the 2.1.3 in 1) above 
5) ran up Audacity from there to check it was latest 2.3.0
6) examined keyboard prefs - Previous Tool had A assigned - About Audacity had nothing assigned
7) In keyboard prefs I set A to be shortcut for About Audacity
8) It warned me that it was already assigned and did I want to replace - I aid yes and OK'd the change.
9)Went back in to keyboard prefs to see what shortcut A was assined to - only About Audacity.

When I repeat this process using a 2.2.2 installation at steps 4-5, then at Step 9 there are indeed two shortcuts for A - the new About Audacity and the old Previous Tool.


Accordingly I believe this bug is fixed - and shall mark it so
First Last Prev Next    This bug is not in your last search results.