Bug 1800 – Custom shortcuts can be overwritten without warning using Full set or importing shortcuts

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1800 - Custom shortcuts can be overwritten without warning using Full set or importing shortcuts


Summary:	Custom shortcuts can be overwritten without warning using Full set or importi...

Status:	CLOSED MOVED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.2.2
Hardware:	Per OS Other

Importance:	P3 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2017-12-11 11:57 UTC by Peter Sampson
Modified:	2021-09-02 11:57 UTC (History)
CC List:	6 users (show)

See Also:
Steps To Reproduce:	Steps to reproduce: 1) clear config files (default Standard shortcuts) 2) set "A" as a shortcut for "Tracks>Sync-Lock Tracks (on/off) 3) observe that this works ok with no warning or blocking error 4) test that the "A" shortcut works as intended to to, toggling Sync-Lock 5) Edit>Preferences>Keyboard and select the "Full" set of shortcut 6) observe that this works ok with no warning or blocking error 7) Now test the"A" shortcut - it advances through the Tools in the Tools toolbar - and does not toggle the Sync-Lock state 8) Edit>Preferences>Keyboard - a search on the key "A" confirms that it is no longer assigned to sync-lock 9) Restore the Standard shortcut set 10) observe that this works ok with no warning or blocking error 11) observe that the "A" shortcut now does nothing
Release Note:	Group: Shortcuts If when working with the default Standard shortcut set you set a custom shortcut that conflicts with one that is assigned in the Full shortcut set (but not in play) and then implement the Full set of shortcuts then your custom shortcut will be overwritten without warning.
First Git SHA:
Group:	---
Workaround:	1) temporarily set the Full short cut set to be on 2) try adding your custom shortcut(s_ 3) if conflicts exists you will be warned 4) restore the reduced Standard set of shortcuts 5) now add your custom shortcuts
Closed:	2021-09-02 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Sampson 2017-12-11 11:57:53 UTC

If a user has the Standard set of shortcuts (default) - and then they
set a custom shortcut and select a key that is in the extended Full set.
a) this is allowed
b) it is silent with no warning

c) If the user then decides they want to activate the full set, their previously set custom shortcut is silently over-writtten with no warning message.

This can also happen at c) (Steps 5-6 in the Steps) if the user attempts to import a set of shortcuts which would cause an over-write (again with no warning)


While the no-warn behavior at step 3 (or b here) is probably OK, as the requested custom key/key-combination is available - and there is no loss of settings.

However at Steps 5-6 (c here) then a warning should be issued giving the user the  chance to accept the overwrite - or abort the Full set/import.


Note that we do already give such a warning when a user manually tries to set a shortcut is already in use - so a warning in this use case here would be consistent.

Comment 1 Peter Sampson 2017-12-11 11:58:38 UTC

James wrote by email:

Also same thing when importing a set of shortcuts.

If doing one, should do both, and should use the same code.  For example reporting '5 shortcuts that you have set up are used by this set.  You will lose them.  Continue anyway?  YES NO'

Comment 2 Peter Sampson 2018-12-18 08:17:41 UTC

If the user restores the Standard set of shortcuts their custom shortcuts overwritten by the Full set are not restored - permananently lost.

Comment 3 Peter Sampson 2021-09-02 11:57:20 UTC

closed in favor of GitHub Issue 1603
https://github.com/audacity/audacity/issues/1603