Bugzilla – Bug 1812
Drag&drop import of Audio considerably slowed/delayed
Last modified: 2018-08-20 11:45:32 UTC
something has gone wrong, got a lot worse, for import of audio files using drag&drop with#the latest Mac alpha nightly audacity-macos-nightly-2.2.2-7ec5fd7.dmg - 26.11 MB | version: 2.2.2--01Jan18 1) with both MP3 and MP4(AAC) files I get a 6-7 second delay with a) 1-2 seconds of a green circle with white plus sign - with a black arrow at 10 o'clock on the circle b) 5-6 seconds of the spinning beach-ball of death Only then does the import progress dialog show and the file is imported OK 2) With WAV files it is similar but worse - the delay her is around 41 secods with step b's spinning beach-ball present for 39 seconds. And remember my Mac is a fast one with a 256 SSD These were all 2-3 minute single song files This is a regression on 2.2.1 (and earlier 2.2.2 alphas) where the imports took place immediately. Imports via the menu File>Import are not affected by this Drag&Drop of Note Tracks is not affected - with import taking place immediately.
Steve confirms that this happens on Linux and wrote by email: The delay increases with file size. When dropping a 1 hour stereo WAV file, Audacity freezes while thrashing one CPU core for about 5 minutes, whereas the import would previously take about 5 seconds on this machine. Also, drag and drop of MP3 in debug build gives a non-fatal assert: ../src/common/txtstrm.cpp(94): assert "Assert failure" failed in NextChar(): unexpected decoding result
Fixed at https://github.com/audacity/audacity/commit/3c9cdac778db83388c0a15ea371a60dd54ef8b02
(In reply to Paul L from comment #2) Testing on macOS 10.13.2 High Sierra with audacity-macos-nightly-2.2.2-e0970ad.dmg - 26.15 MB | version: 2.2.2--02Jan18 Looks to be back to normal with no delays no beach-balls prior to the loading. Marked as OK on Mac. With no Windows nightlies I cannot text on W10
Can we be a bit bolder in marking bugs resolved? This bug only needed to be tested on one platform. It has been tested by two people who were not the fixer, so I am marking it: RESOLVED FIXED.
(In reply to James Crook from comment #4) We can be "bolder" - but personally I would ideally prefer to see this working on Windows, as our major platform by far, before marking this resolved. With a Windows nightly build re-established, this could be realized.
(In reply to James Crook from comment #4) Paul initially suggested that the problem could be platform dependent, so in this case I think it was reasonable to wait for confirmation on all platforms.
Flagged as Must-Test-All-OS and moving back into DEVEL - FIX MADE
Tested on a 2.2.2 Windows build that Hames made for me 2.2.2 JC002 07Jan18 I confirm this is fine on W10 with no delay before import. A side issue (also reso9lved - a recent forum post indicated thet we had introduced a slowdown on WAV import for 2.2.0 and 2.2.1 - this appears to be OK again in 2.2.2 alpha: https://forum.audacityteam.org/viewtopic.php?f=46&t=98363
