Bug 1843 – Tracks menu error messages do not have "?" help butttons to link to the Manual

••• Introduction •••
••• Keywords •••

Audacity 3.0.3 development began 19th April 2021

Audacity Bugzilla

Bug 1843 - Tracks menu error messages do not have "?" help butttons to link to the Manual


Summary:	Tracks menu error messages do not have "?" help butttons to link to the Manual

Status:	RESOLVED FIXED

Product:	Audacity
Classification:	Unclassified
Component:	User Interface
Version:	2.2.2
Hardware:	Per OS All

Importance:	P2 RepeatableAll
Assigned To:	Default Assignee for New Bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2018-02-22 05:53 UTC by Peter Sampson
Modified:	2019-08-07 14:45 UTC (History)
CC List:	6 users (show)

See Also:
Steps To Reproduce:	1. record some audio 2. ensure you do not select the track or any audio 3. use any item from the Tracks menu that requires a selection 4. observe that none of the messages has a "?" help button to link to the Manual
Release Note:
First Git SHA:
Group:	---
Workaround:
Closed:	2019-08-07 00:00:00

Flags:	petersampsonaudacity: Test‑OK‑Win+ petersampsonaudacity: Test‑OK‑Mac+ stevethefiddle: Test‑OK‑Lin+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Sampson 2018-02-22 05:53:41 UTC

None of the  error messages in the Tracks menu appear to have a "?" help button to link to the Manual.

This is inconsistent with our current Audacity practice elsewhere in the app.

Comment 1 Peter Sampson 2018-02-22 05:54:21 UTC

see also Bug #1842

Comment 2 Steve Daulton 2018-02-25 21:18:53 UTC

(In reply to Peter Sampson from comment #0)
Does it need a help button?
The message seems pretty clear to me - you need to select a track - what more is there to say?

Comment 3 Peter Sampson 2018-02-26 07:29:41 UTC

You could argue exactly the same for say the Amplify effect when no audio is selected.

hence my reference to "consistency" in Comment #0

Comment 4 James Crook 2019-07-17 08:22:28 UTC

DEVEL - FIX MADE
https://github.com/audacity/audacity/commit/07465845ddabd8a3d42f8b53885150392eb125fb

Comment 5 Peter Sampson 2019-07-18 04:10:57 UTC

(In reply to James Crook from comment #4)
Testing on W10 with audacity-2.3.3-alpha-296-13348841c038bdd7614ae9e401ad0a419f7fb44a

There are now Help buttons on the relevant error dialogs - but they go to non-existent pages in the Manual:
a) "FAQ:Errors:Select Audio"
b) "FAQ:Errors:Select Track"

Apart from the fact that this is not the way the FAQ Errors page is organized in the Manual (basically there are not sub-pages)...

The proper target page for these help buttons should be:
https://alphamanual.audacityteam.org/man/Audacity_Selection

That page tells them all they need to know about selection - and the error messages are clear that a selection (if audio or tracks as appropriate) is required.

Comment 6 Peter Sampson 2019-07-23 06:44:16 UTC

Elevated to P2 as we really cannot release like this

Comment 7 James Crook 2019-07-23 07:52:16 UTC

DEVEL - FIX MADE for residual.  Links have now been changed to Audacity_Selection.
https://github.com/audacity/audacity/commit/87a4a21becf1f7c1b8e82951f094bc18e0439c0f

Comment 8 Peter Sampson 2019-07-23 08:09:31 UTC

Testing on W10 with audacity-2.3.3-alpha-301-87a4a21becf1f7c1b8e82951f094bc18e0439c0f

This now works properly on W10 accessing the required target page on Selection in the Manual

Comment 9 Peter Sampson 2019-07-26 05:01:31 UTC

(In reply to James Crook from comment #7)
Testing on macOS 10.14.5 with mac 2.3.3 alpha jc004 of 25Jul19

This  also now works properly on Mac accessing the required target page on Selection in the Manual

Comment 10 Steve Daulton 2019-08-07 14:45:36 UTC

Help buttons are present and working on Linux.
Closing as Fixed.